Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop k8s v1.28 from kind testing and update cluster version to 1.30 in e2e #15655

Merged
merged 5 commits into from
Dec 28, 2024
Merged

Drop k8s v1.28 from kind testing and update cluster version to 1.30 in e2e #15655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
026f528
Drop k8s v1.28 from kind testing and update cluster version to 1.29 i…
skonto Dec 17, 2024
4e0ef18
remove 1.29
skonto Dec 17, 2024
fbdd1db
add 1.29 back
skonto Dec 19, 2024
843cd52
revert chainguard-dev/actions/setup-kind to main
skonto Dec 20, 2024
9166d3b
set min to 1.30
skonto Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/kind-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ jobs:
fail-fast: false # Keep running if one leg fails.
matrix:
k8s-version:
- v1.28.x
- v1.29.x
- v1.30.x
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to test all three or two are good enough.

- v1.31.x
Copy link
Contributor Author

@skonto skonto Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it too expensive to test three versions? I could have updated to 1.32 but this was just released so we can upgraded later, wanted to move incrementally without skipping a version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea is that we have a min version and for the the API compat-check the next one.

Copy link
Contributor Author

@skonto skonto Dec 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok at the time of the cut of 1.17 there will be 1.29 around so I will update that one (End of Life:2025-02-28).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: 1.29 enters maintenance in December will move to 1.30 as the minimum.


ingress:
- kourier
Expand Down Expand Up @@ -170,7 +170,7 @@ jobs:
path: ~/artifacts

- name: setup kind
uses: chainguard-dev/actions/setup-kind@1f79ee3c1d554f67a5344933e2cadfa4b58d300d
uses: chainguard-dev/actions/setup-kind@main
with:
k8s-version: ${{ matrix.k8s-version }}
kind-worker-count: 4
Expand Down
2 changes: 1 addition & 1 deletion test/e2e-external-domain-tls-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ function delete_dns_record() {
}

# Script entry point.
initialize "$@" --num-nodes=4 --enable-ha --cluster-version=1.28
initialize "$@" --num-nodes=4 --enable-ha --cluster-version=1.30

# Run the tests
header "Running tests"
Expand Down
2 changes: 1 addition & 1 deletion test/e2e-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
source $(dirname "$0")/e2e-common.sh

# Script entry point.
initialize --num-nodes=4 --enable-ha --cluster-version=1.28 "$@"
initialize --num-nodes=4 --enable-ha --cluster-version=1.30 "$@"

# Run the tests
header "Running tests"
Expand Down
2 changes: 1 addition & 1 deletion test/e2e-upgrade-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function stage_test_resources() {
# Skip installing istio as an add-on.
# Skip installing a pvc as it is not used in upgrade tests
# Skip installing a resource quota as it is not used in upgrade tests
PVC=0 QUOTA=0 initialize "$@" --num-nodes=4 --cluster-version=1.28 \
PVC=0 QUOTA=0 initialize "$@" --num-nodes=4 --cluster-version=1.30 \
--install-latest-release

# TODO(#2656): Reduce the timeout after we get this test to consistently passing.
Expand Down
2 changes: 1 addition & 1 deletion test/performance/performance-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ declare ARTIFACTS

ns="default"

initialize --num-nodes=10 --cluster-version=1.28 "$@"
initialize --num-nodes=10 --cluster-version=1.30 "$@"

function run_job() {
local name=$1
Expand Down
Loading