Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop k8s v1.28 from kind testing and update cluster version to 1.30 in e2e #15655

Merged
merged 5 commits into from
Dec 28, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Dec 17, 2024

Proposed Changes

We (the community) support the range of upstream minor Kubernetes versions that are Kubernetes community supported at the time of the cut. This excludes releases which have entered maintenance mode. Only the latest patch release of the minor version is tested for support. Support for versions prior to that are best effort, or by vendors.
Adoption of newer K8s minimum versions will also be on a best-effort basis. When a Kubernetes version is released it's availability in downstream distributions is often lagging. When these delays affect our planned min K8s version we'll update the version table below and make it known in the release's notes.

From a vendors pov (stable channels):

@skonto skonto requested a review from ReToCode December 17, 2024 10:43
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 17, 2024
@knative-prow knative-prow bot requested a review from izabelacg December 17, 2024 10:43
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.49%. Comparing base (06281eb) to head (843cd52).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15655      +/-   ##
==========================================
- Coverage   83.54%   83.49%   -0.06%     
==========================================
  Files         219      219              
  Lines       17427    17427              
==========================================
- Hits        14560    14551       -9     
- Misses       2497     2503       +6     
- Partials      370      373       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto skonto removed the request for review from izabelacg December 17, 2024 10:50
- v1.29.x
- v1.30.x
- v1.31.x
Copy link
Contributor Author

@skonto skonto Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it too expensive to test three versions? I could have updated to 1.32 but this was just released so we can upgraded later, wanted to move incrementally without skipping a version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea is that we have a min version and for the the API compat-check the next one.

Copy link
Contributor Author

@skonto skonto Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok at the time of the cut of 1.17 there will be 1.29 around so I will update that one (End of Life:2025-02-28).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: 1.29 enters maintenance in December will move to 1.30 as the minimum.

@skonto skonto requested a review from dprotaso December 17, 2024 11:33
@skonto
Copy link
Contributor Author

skonto commented Dec 17, 2024

cc @dprotaso

@skonto
Copy link
Contributor Author

skonto commented Dec 17, 2024

As @ReToCode pointed out 1.17 is going to support 1.30 (https://github.com/knative/community/blob/main/mechanics/RELEASE-SCHEDULE.md) so I will remove 1.29.

@skonto skonto changed the title Drop k8s v1.28 from kind testing and update cluster version to 1.29 in e2e Drop k8s v1.28 from kind testing and update cluster version to 1.30 in e2e Dec 17, 2024
@skonto
Copy link
Contributor Author

skonto commented Dec 17, 2024

We also need to update depds and k8s-minimum at the knative/pkg side. Will do a PR.

@skonto
Copy link
Contributor Author

skonto commented Dec 17, 2024

It seems we missed updating the minimum for 1.16.

@skonto
Copy link
Contributor Author

skonto commented Dec 17, 2024

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
@skonto
Copy link
Contributor Author

skonto commented Dec 17, 2024

knative/pkg#3124

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold for the pkg one

- v1.29.x
- v1.30.x
- v1.31.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea is that we have a min version and for the the API compat-check the next one.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@skonto skonto changed the title Drop k8s v1.28 from kind testing and update cluster version to 1.30 in e2e Drop k8s v1.28 from kind testing and update cluster version to 1.29 in e2e Dec 19, 2024
@ReToCode
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
Copy link

knative-prow bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@skonto skonto changed the title Drop k8s v1.28 from kind testing and update cluster version to 1.29 in e2e Drop k8s v1.28 from kind testing and update cluster version to 1.30 in e2e Dec 20, 2024
@@ -82,8 +82,8 @@ jobs:
fail-fast: false # Keep running if one leg fails.
matrix:
k8s-version:
- v1.28.x
- v1.29.x
- v1.30.x
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to test all three or two are good enough.

@dprotaso
Copy link
Member

dprotaso commented Dec 28, 2024

/hold cancel
/lgtm

let's add k8s 1.32 kind testing in a follow up

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 28, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 28, 2024
@knative-prow knative-prow bot merged commit 750f9a2 into knative:main Dec 28, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants