-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop k8s v1.28 from kind testing and update cluster version to 1.30 in e2e #15655
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15655 +/- ##
==========================================
- Coverage 83.54% 83.49% -0.06%
==========================================
Files 219 219
Lines 17427 17427
==========================================
- Hits 14560 14551 -9
- Misses 2497 2503 +6
- Partials 370 373 +3 ☔ View full report in Codecov by Sentry. |
- v1.29.x | ||
- v1.30.x | ||
- v1.31.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it too expensive to test three versions? I could have updated to 1.32 but this was just released so we can upgraded later, wanted to move incrementally without skipping a version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the idea is that we have a min version and for the the API compat-check the next one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok at the time of the cut of 1.17 there will be 1.29 around so I will update that one (End of Life:2025-02-28).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: 1.29 enters maintenance in December will move to 1.30 as the minimum.
cc @dprotaso |
As @ReToCode pointed out 1.17 is going to support 1.30 (https://github.com/knative/community/blob/main/mechanics/RELEASE-SCHEDULE.md) so I will remove 1.29. |
We also need to update depds and k8s-minimum at the knative/pkg side. Will do a PR. |
It seems we missed updating the minimum for 1.16. |
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold for the pkg one
- v1.29.x | ||
- v1.30.x | ||
- v1.31.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the idea is that we have a min version and for the the API compat-check the next one.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -82,8 +82,8 @@ jobs: | |||
fail-fast: false # Keep running if one leg fails. | |||
matrix: | |||
k8s-version: | |||
- v1.28.x | |||
- v1.29.x | |||
- v1.30.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to test all three or two are good enough.
/hold cancel let's add k8s 1.32 kind testing in a follow up |
Proposed Changes
From a vendors pov (stable channels):