Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redesign: dynamic change grid card size #4444

Closed
yangwao opened this issue Dec 4, 2022 · 10 comments
Closed

redesign: dynamic change grid card size #4444

yangwao opened this issue Dec 4, 2022 · 10 comments
Labels
$ ~<50usd p2 core functionality, or is affecting 60% of app redesign

Comments

@yangwao
Copy link
Member

yangwao commented Dec 4, 2022

change grid card size

Right now current trends and our anticipation of bringing dynamics cards as now we have columns of fixed ones. It's nice, but not everyone has same screensize and we would maximalize unified experience at each of screen size. Ranging from mobile, folding phones, tablet, notebook to desktop.

You can currently see trend on R & OS that dynamic cards has some properties where they sizing these cards dynamically on picture and description.
In similar manner we will set some break points to have it

Just backlogging as can easily sink through our thought process among others and I found it really important stuff to have.

Of course, we will welcome to have some sort of override where user can set "size" of card, but amount of columns will be adjusted dynamically for best user experience

Originally posted by @yangwao in #4378 (comment)

Please reflect on foldable phones. ht @exezbcz finding foldable explainer for proper CSS ninjas :P

Ref

@exezbcz
Copy link
Member

exezbcz commented Dec 14, 2022

as mentioned in issue #4496, we have some sort of minimal card size.

The grid, size of the cards and the number of cards will change based on few factors

  • there is going to be fixed gap between them - for bigger cards in normal view its 32px and for the smaller cards its 24px
  • once the card can not be smaller without lowering/increasing the gap, the amount will be lowered by one/required.
  • other cards will scale up so there is the demanded gap - Same when scaling up.

Have a look at rarible/opensea.

in our case - explore with filter with menu opened/closed.

image

- at the bottom there are the minimum size cards and demanded gap between them. - Once we open the filter menu, they would not fit. Certain number of cards are removed and the others scale up.

explore v0.9 figma here: https://www.figma.com/file/OwAEyE0QDPn3tHXZbyot1o/Explore-v0.9?node-id=0%3A1&t=Mp5WHz4Ig8kbcIsy-3

lmk if the approach is not great or it could be done differently

@exezbcz exezbcz added p3 non-core, affecting less than 40% $ ~<50usd and removed design-request p5 ideas for future labels Dec 14, 2022
@yangwao
Copy link
Member Author

yangwao commented Dec 20, 2022

At collection, we should apply it as well once the following PR is merged, that we should preserve some card size on collection view as well

@exezbcz
Copy link
Member

exezbcz commented Jan 6, 2023

Anyone 🥺
image

@yangwao yangwao mentioned this issue Feb 1, 2023
25 tasks
@yangwao yangwao added p2 core functionality, or is affecting 60% of app and removed p3 non-core, affecting less than 40% labels Feb 3, 2023
@exezbcz
Copy link
Member

exezbcz commented Feb 9, 2023

Me every month checking this issue:

@yangwao
Copy link
Member Author

yangwao commented Feb 16, 2023

This will be reused for

@yangwao
Copy link
Member Author

yangwao commented Feb 22, 2023

We should think of height of collection cards on wider screens
image

@preschian
Copy link
Member

I just pushed a new branch for dynamic grids. @exezbcz @yangwao you can check it in here https://feat-dynamic-grid.nft-gallery-5ci.pages.dev/bsx/collection/14022023?page=3&redesign=true

I don't put the resize event listener. so need to resize the page first and then refresh it to see the result. you can check the result on the collection page/explore items page/user page under redesign=true query

@exezbcz
Copy link
Member

exezbcz commented Feb 24, 2023

@preschian uuu nice, it seems like things are improving! I'll play with it for a while and give feedback; at first glance, it looks to be good.

@yangwao
Copy link
Member Author

yangwao commented Feb 27, 2023

you can check it in here

very nice! I think the card ratio is close to perfect for me on 13"

@yangwao
Copy link
Member Author

yangwao commented Mar 1, 2023

Ah, collection is solved in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd p2 core functionality, or is affecting 60% of app redesign
Projects
None yet
Development

No branches or pull requests

3 participants