-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redesign: dynamic change grid card size #4444
Comments
as mentioned in issue #4496, we have some sort of minimal card size. The grid, size of the cards and the number of cards will change based on few factors
Have a look at rarible/opensea. in our case - explore with filter with menu opened/closed. - at the bottom there are the minimum size cards and demanded gap between them. - Once we open the filter menu, they would not fit. Certain number of cards are removed and the others scale up.explore v0.9 figma here: https://www.figma.com/file/OwAEyE0QDPn3tHXZbyot1o/Explore-v0.9?node-id=0%3A1&t=Mp5WHz4Ig8kbcIsy-3 lmk if the approach is not great or it could be done differently |
At collection, we should apply it as well once the following PR is merged, that we should preserve some card size on collection view as well |
This will be reused for |
I just pushed a new branch for dynamic grids. @exezbcz @yangwao you can check it in here https://feat-dynamic-grid.nft-gallery-5ci.pages.dev/bsx/collection/14022023?page=3&redesign=true I don't put the |
@preschian uuu nice, it seems like things are improving! I'll play with it for a while and give feedback; at first glance, it looks to be good. |
very nice! I think the card ratio is close to perfect for me on 13" |
Ah, collection is solved in |
Right now current trends and our anticipation of bringing dynamics cards as now we have columns of fixed ones. It's nice, but not everyone has same screensize and we would maximalize unified experience at each of screen size. Ranging from mobile, folding phones, tablet, notebook to desktop.
You can currently see trend on R & OS that dynamic cards has some properties where they sizing these cards dynamically on picture and description.
In similar manner we will set some break points to have it
Just backlogging as can easily sink through our thought process among others and I found it really important stuff to have.
Of course, we will welcome to have some sort of override where user can set "size" of card, but amount of columns will be adjusted dynamically for best user experience
Originally posted by @yangwao in #4378 (comment)
Please reflect on foldable phones. ht @exezbcz finding foldable explainer for proper CSS ninjas :P
Ref
The text was updated successfully, but these errors were encountered: