Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass listing v1 #6941

Closed
exezbcz opened this issue Aug 25, 2023 · 20 comments · Fixed by #7076
Closed

Mass listing v1 #6941

exezbcz opened this issue Aug 25, 2023 · 20 comments · Fixed by #7076
Labels
$$ ~51-150usd A-modal issues related to modals A-profile related to profile section intern tasks intended for internal team p2 core functionality, or is affecting 60% of app

Comments

@exezbcz
Copy link
Member

exezbcz commented Aug 25, 2023

image

fast and furious mass listing

Main

Design

Cards

  • same states as with cart cards
  • divides into two types - items without price -> list for sale popup button, items with price -> change price (if it's complicated, we can left out this part)
image
  • Check when item is active and selected, please keep the button width between the states
image

Smol toast

image
  • 16px from the desktop margins - does not blend with the cards
  • item count, option to clear all, select all - select all means everything you own.
  • This toast is not tab-fixed, it works basically like a small cart. It has position absolute and always shows till you close the profile
    now for what happens when you click the action button

Modal

  • you are presented with a confirmation modal like modal :D

Top part

image
  • there are two options
  • Both set all the items under to the price you select
  • either you select floor price, or fixed price
  • percentage selectors (based on the items collection floor price)
  • you have to confirm fixed price before it is applied - small button check
  • floor price and the percentages need to be only clicked to be selected, no active state here, It will just updated price of all the items
image

Items

  • item has a preview, collection name, name, and option to remove it from your listings list. There is also collection floor, if there is none, it will display "--", then there is input with currency
image - input behaves like all the inputs before, same with mass mint, minting, etc. - it also has placeholder text, "price"

Bottom part

image
  • cta button with a summary of the action
  • there is an estimate of the potential earnings. It is just the total of all the listings prices
  • the button is disabled till you fill out all the items, there will be also a count of items you have to fill out
image

Please look at all the margins and paddings

I think that is all for the mass listing. If you have any questions, feel free to tag me! 🚀

@exezbcz exezbcz added p2 core functionality, or is affecting 60% of app intern tasks intended for internal team A-profile related to profile section A-modal issues related to modals labels Aug 25, 2023
@yangwao yangwao added the $$ ~51-150usd label Aug 25, 2023
@xiiiAtCn
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Aug 25, 2023

ASSIGNED - @xiiiAtCn 🔒 LOCKED -> Sunday, August 27th 2023, 12:04:31 UTC -> 48 hours

@kodabot
Copy link
Collaborator

kodabot commented Aug 25, 2023

ASSIGNMENT OVER - @xiiiAtCn has been unassigned.

@yangwao
Copy link
Member

yangwao commented Aug 25, 2023

👋

hey this is reserved for @kodadot/internal-dev team as this issue has "intern" label :)

@xiiiAtCn
Copy link
Contributor

Sorry.Not notify this label.

@yangwao
Copy link
Member

yangwao commented Aug 27, 2023

Hey, @kodadot/internal-dev, who wants to grab this one? 😄

We will then start providing small liquidity/trading experiments. 👀

@stephenjason89
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Aug 28, 2023

ASSIGNED - @stephenjason89 🔒 LOCKED -> Thursday, August 31st 2023, 12:15:45 UTC -> 72 hours

@stephenjason89
Copy link
Contributor

blocked by #7016

@yangwao
Copy link
Member

yangwao commented Aug 30, 2023

blocked by #7016

feel free raise what you have in PR and we can make it follow up

@vikiival
Copy link
Member

blocked by #7016

Resolved in the meantime

but transaction on bsx chain should pass anyway

@stephenjason89
Copy link
Contributor

stephenjason89 commented Aug 30, 2023

@vikiival Thank you! I can confirm that it is working now.
I'll work on it tomorrow. It's midnight here 😄

@yangwao
Copy link
Member

yangwao commented Aug 30, 2023

It's midnight here 😄

mind sleep please 👀

@kodabot
Copy link
Collaborator

kodabot commented Aug 31, 2023

ASSIGNMENT EXPIRED - @stephenjason89 has been unassigned.

@stephenjason89
Copy link
Contributor

I'll finish this tomorrow 😄
@exezbcz Just want to confirm, change price will also add the nft to the list cart together with all the other items listed for sale correct?

@exezbcz
Copy link
Member Author

exezbcz commented Aug 31, 2023

@stephenjason89 select all will select only the unlisted one

  • If you also select items with price, they could be added to the mass list modal if it is not overcomplicated

@stephenjason89
Copy link
Contributor

Noted on this.

If you also select items with price, they could be added to the mass list modal if it is not overcomplicated

It's alright. Not too complicated ❤️

Besides this cat I always see while testing
image

@exezbcz
Copy link
Member Author

exezbcz commented Aug 31, 2023

Besides this cat I always see while testing

she is cute

@stephenjason89
Copy link
Contributor

@exezbcz I finalized the Layout of UI. Let me know what you think.
Last thing to do is to save the transactions now.

@exezbcz
Copy link
Member Author

exezbcz commented Sep 1, 2023

@stephenjason89 lets move to the pr sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ ~51-150usd A-modal issues related to modals A-profile related to profile section intern tasks intended for internal team p2 core functionality, or is affecting 60% of app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants