Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mass listing #7076

Merged
merged 52 commits into from
Sep 6, 2023
Merged

feat: mass listing #7076

merged 52 commits into from
Sep 6, 2023

Conversation

stephenjason89
Copy link
Contributor

@stephenjason89 stephenjason89 commented Aug 31, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 0c66f2c

This pull request implements a listing cart feature for NFT owners who want to sell their items. It adds a new stores/listingCart module that defines a Pinia store for managing the cart state and actions, and uses local storage for persistence. It also modifies the ItemsGridImage component to display a button for adding items to the cart.

🤖 Generated by Copilot at 0c66f2c

You have the power to sell your art
But beware of the listing cart
It will sync with your local storage
And unleash the Pinia carnage

@kodabot
Copy link
Collaborator

kodabot commented Aug 31, 2023

WARNING @stephenjason89 PR for issue #6941 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6941

@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit edd67df
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64f73f81f7a26c0008189ef4
😎 Deploy Preview https://deploy-preview-7076--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 31, 2023

AI-Generated Summary: This pull request introduces the feature of listing items in a cart. Changes are made to the file ItemsGridImage.vue, which now includes new functionalities such as listing items for sale and checking if an item is already in the cart. This is possible through using the store listingCart.ts. This new file has been added to manage the listings in the cart. It includes definitions for different actions such as setting an item, updating an item, removing an item, and clearing the cart. These functionalities utilize local storage for persistence. A total of 92 lines have been added in this update spread across two files. The purpose of this update is to enhance the user’s shopping experience by keeping track of their potential purchases.

@reviewpad reviewpad bot added the small Pull request is small label Aug 31, 2023
stores/listingCart.ts Outdated Show resolved Hide resolved
@reviewpad reviewpad bot added medium Pull request is medium and removed small Pull request is small labels Aug 31, 2023
@reviewpad reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Sep 1, 2023
@yangwao
Copy link
Member

yangwao commented Sep 1, 2023

Can we try to test it?

Interesting 🤔 progress of sizing
From small, through medium till largest

Screenshot_20230901_095334_GitHub.jpg

@stephenjason89
Copy link
Contributor Author

@yangwao maybe in 3hours i'll be done
Just gonna save the transactions 😄

@exezbcz
Copy link
Member

exezbcz commented Sep 1, 2023

hello!

nice job, I will continuously check the pr:

First round

image - select all should select the cards, giving them the added to list status - blue bg and stroke etc...
  • this thing should be displayed after at least one item is added:
image please check the styling : ![image](https://github.com/kodadot/nft-gallery/assets/90852205/4afdd5a7-de9f-41d2-a724-ea256bd32848)

clicking floor in the modal does nothing even thought there is the collection floor price :
image

check dark mode input styling please:

image

smaller thrash icon here:
image

otherwise really solid! thank you @stephenjason89, next round soon :D

@stephenjason89
Copy link
Contributor Author

stephenjason89 commented Sep 1, 2023

hello!

nice job, I will continuously check the pr:

otherwise really solid! thank you @stephenjason89, next round soon :D

Thank you @exezbcz for pointing out the dark theme issue. I am glad you liked the layout and everything was good.

Yup all the other functionalities are not yet implemented but I am almost done with it.

Will push a PR in a while.

@stephenjason89
Copy link
Contributor Author

@exezbcz Please check PR. This is almost final. Will just have to save this on the chain now and i will remove this from draft.

Thank you

@exezbcz
Copy link
Member

exezbcz commented Sep 1, 2023

  • this thing should be displayed after at least one item is added

missing

styling:
image

left padding for the placeholder please
image

@stephenjason89
Copy link
Contributor Author

  • this thing should be displayed after at least one item is added

Oh okay, I thought it should always show so a user can do a Select All initially. But yes hiding it is good also, that's what i want to do initially.

missing

styling: image

left padding for the placeholder please image

noted on this.

@daiagi
Copy link
Contributor

daiagi commented Sep 5, 2023

image

same issue as #7121

@stephenjason89
Copy link
Contributor Author

stephenjason89 commented Sep 5, 2023

@daiagi this is how it looks on my end on the latest deployment
image
How can i replicate that issue?
Have you tried clearing your cache?

@daiagi
Copy link
Contributor

daiagi commented Sep 5, 2023

this is how it looks on my end on the latest deployment

don't worry about it, it is dealt with in #7121. I've just linked it here so prury or execbcz know that it isn't from this pr

components/common/listingCart/ListingCartModal.vue Outdated Show resolved Hide resolved
components/common/listingCart/ListingCartModal.vue Outdated Show resolved Hide resolved
components/common/listingCart/ListingCartModal.vue Outdated Show resolved Hide resolved
components/common/shoppingCart/utils.ts Outdated Show resolved Hide resolved
components/items/ItemsGrid/ItemsGrid.vue Outdated Show resolved Hide resolved
components/items/ItemsGrid/ItemsGridImage.vue Outdated Show resolved Hide resolved
stores/listingCart.ts Outdated Show resolved Hide resolved
stores/listingCart.ts Outdated Show resolved Hide resolved
stores/listingCart.ts Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Sep 5, 2023

Code Climate has analyzed commit edd67df and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yangwao
Copy link
Member

yangwao commented Sep 5, 2023

I think it's time for merge, and we can do followups. 😄

image

@stephenjason89
Copy link
Contributor Author

stephenjason89 commented Sep 5, 2023

I think it's time for merge, and we can do followups. 😄

image

Yeah haha let's do this 😅
Most of the code changes were code style, syntax, global css helpers, and translations.

I think we've addressed everything already 😂

@prury prury self-requested a review September 5, 2023 17:43
@daiagi
Copy link
Contributor

daiagi commented Sep 5, 2023

Alright.
Thank you for your patience with the extended reviews
Let it roll

@daiagi daiagi removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Sep 5, 2023
@yangwao
Copy link
Member

yangwao commented Sep 6, 2023

pay 100 usd

@yangwao yangwao merged commit fe27703 into kodadot:main Sep 6, 2023
@yangwao
Copy link
Member

yangwao commented Sep 6, 2023

😍 Perfect, I’ve sent the payout
💵 $100 @ 4.23 USD/DOT ~ 23.641 $DOT
🧗 13rFRPVKjJzQXVC8ZqHZv5YMmwmk4MU7z4HeYk218hEMpQXH
🔗 0xe879ce52e338193cf5881d94ccab1c2a1201cdd790318ab3a6d74254a931eed8

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Sep 6, 2023
@daiagi daiagi mentioned this pull request Sep 6, 2023
16 tasks
@exezbcz exezbcz mentioned this pull request Sep 18, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large paid pull-request has been paid waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mass listing v1
9 participants