New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix value processor. Cover with tests. #14

Merged

lexbritvin merged 2 commits into main from fixprocessor

Jan 21, 2025

Collaborator

lexbritvin commented Jan 21, 2025

No description provided.

lexbritvin added 2 commits

January 21, 2025 11:44


          Fix value processor. Cover with tests.

abc8628


          Fix value processor. Cover with tests.

a2b48a6

lexbritvin merged commit 9ab631f into main

4 checks passed

Contributor

davidferlay commented Jan 22, 2025

Unexpected change in behavior:

Observed: User is not prompted anymore for value in case it is not passed as argument
Expected: User should be prompted for value in case it is not passed as argument

➜ plasmactl keyring:set vaultpass // old plasmactl
Value:                                                
➜ ./plasmactl keyring:set vaultpass // new plasmactl
  ERROR   validation errors:
            - [arguments value]: got null, want string

It should also be possible to pass value as arg/option. Both ways to input value is required

➜ plasmactl keyring:set vaultpass --help // old plasmactl
Keyring: Set: Store new key-value pair to keyring

Usage:
  plasmactl keyring:set key value [flags]

➜ ./plasmactl keyring:set vaultpass --help // new plasmactl
Keyring: Set: Store new key-value pair to keyring

Usage:
  plasmactl keyring:set key value [flags]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet