#39: Login error: standard input is not a terminal

.github/workflows/manual.yml

@@ -0,0 +1,24 @@
+name: Ensure no TTY if user does not need to input anythin
+on:
+  push:
+  workflow_dispatch:
+
+jobs:
+  job1:
+    name: Login
+    runs-on: ubuntu-latest
+    env:
+      TOKEN_JSON: ${{ secrets.TOKEN_JSON }}
+      CREDENTIALS_JSON: ${{ secrets.CREDENTIALS_JSON }}
+    steps:
+    - name: Git checkout
+      uses: actions/checkout@v3
+    - name: Commands
+      run: |
+        echo
+        date
+        pwd
+        whoami
+        make all
+        ls -lah bin/launchr
+        ./bin/launchr login --url=http://***.git --username="***" --password="***" --keyring-passphrase="***"

plugin.go

@@ -206,12 +206,14 @@ func buildNotFoundError(item, template string, err error) error {
 
 func login(k Keyring, creds CredentialsItem) error {
 	// Ask for login elements if some elements are empty.
-	err := RequestCredentialsFromTty(&creds)
-	if err != nil {
-		return err
+	if creds.isEmpty() {
+		err := RequestCredentialsFromTty(&creds)
+		if err != nil {
+			return err
+		}
 	}
 
-	err = k.AddItem(creds)
+	err := k.AddItem(creds)
 	if err != nil {
 		return err
 	}
@@ -220,12 +222,14 @@ func login(k Keyring, creds CredentialsItem) error {
 
 func saveKey(k Keyring, item KeyValueItem) error {
 	// Ask for login elements if some elements are empty.
-	err := RequestKeyValueFromTty(&item)
-	if err != nil {
-		return err
+	if item.isEmpty() {
+		err := RequestKeyValueFromTty(&item)
+		if err != nil {
+			return err
+		}
 	}
 
-	err = k.AddItem(item)
+	err := k.AddItem(item)
 	if err != nil {
 		return err
 	}