Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [UIE-8422] - database migration banner #11595

Conversation

mpolotsk-akamai
Copy link
Contributor

@mpolotsk-akamai mpolotsk-akamai commented Feb 3, 2025

Description 📝

Database migration banner for Landing Page

Changes 🔄

List any change(s) relevant to the reviewer.

  • Added banner for Landing Page

Target release date 🗓️

2/11/25

Preview 📷

Before After
Screenshot 2025-02-03 at 2 36 57 PM Screenshot 2025-02-04 at 11 56 56 AM

How to test 🧪

Prerequisites

User should have legacy databases

Verification steps

  • Navigate to the Database Landing Page to see the banner
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mpolotsk-akamai mpolotsk-akamai requested a review from a team as a code owner February 3, 2025 13:39
@mpolotsk-akamai mpolotsk-akamai requested review from mjac0bs and harsh-akamai and removed request for a team February 3, 2025 13:39
Copy link

github-actions bot commented Feb 3, 2025

Coverage Report:
Base Coverage: 79.27%
Current Coverage: 79.27%

@cpathipa cpathipa requested review from cpathipa and removed request for harsh-akamai February 3, 2025 14:52
@cpathipa cpathipa added the DBaaS Relates to Database as a Service label Feb 3, 2025
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change - left some feedback regarding copy and agreeing with the first review on this.

@mpolotsk-akamai mpolotsk-akamai force-pushed the feature/UIE-8422-banner-for-legacy-users branch from 3f57393 to e809e60 Compare February 4, 2025 10:57
@mpolotsk-akamai
Copy link
Contributor Author

@bnussman-akamai , @mjac0bs thank you for the review!
I've updated the copy.

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 494 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing494 Passing2 Skipped99m 49s

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ For users with legacy clusters, banner is visible with clear copy and a support link for users. For users without legacy clusters, banner does not display.

Thanks Mariia!

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Feb 4, 2025
@mjac0bs mjac0bs merged commit 5bbe436 into linode:develop Feb 4, 2025
23 checks passed
Copy link

cypress bot commented Feb 4, 2025

Cloud Manager E2E    Run #7170

Run Properties:  status check passed Passed #7170  •  git commit 5bbe4365cb: feat: [UIE-8422] - database migration banner (#11595)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #7170
Run duration 32m 04s
Commit git commit 5bbe4365cb: feat: [UIE-8422] - database migration banner (#11595)
Committer mpolotsk-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 499
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants