-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [UIE-8422] - database migration banner #11595
feat: [UIE-8422] - database migration banner #11595
Conversation
Coverage Report: ✅ |
packages/manager/src/features/GlobalNotifications/DatabaseMigrationInfoBanner.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/GlobalNotifications/DatabaseMigrationInfoBanner.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change - left some feedback regarding copy and agreeing with the first review on this.
packages/manager/src/features/GlobalNotifications/DatabaseMigrationInfoBanner.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/GlobalNotifications/DatabaseMigrationInfoBanner.tsx
Outdated
Show resolved
Hide resolved
3f57393
to
e809e60
Compare
@bnussman-akamai , @mjac0bs thank you for the review! |
Cloud Manager UI test results🎉 494 passing tests on test run #3 ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ For users with legacy clusters, banner is visible with clear copy and a support link for users. For users without legacy clusters, banner does not display.
Thanks Mariia!
Cloud Manager E2E
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
|
Run duration | 32m 04s |
Commit |
|
Committer | mpolotsk-akamai |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
4
|
|
2
|
|
0
|
|
499
|
View all changes introduced in this branch ↗︎ |
Description 📝
Database migration banner for Landing Page
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
2/11/25
Preview 📷
How to test 🧪
Prerequisites
User should have legacy databases
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅