fix: [M3-9235] - Longview Detail id param not found locally #11599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
requested review from
bnussman-akamai and
hana-akamai
and removed request for
a team
abailly-akamai
commented
Feb 3, 2025
| match: { | ||
| params: { | ||
| id, | ||
| }, | ||
| }, | ||
| params: { | ||
| id, | ||
| }, |
There was a problem hiding this comment.
If anyone has any clue why this was working without this when implemented previously (and why this isn't an issue in production), please let me know. Considering this is working fine and that Longview will be deprecated in the not so long term, I did not do a full investigation.
|
Coverage Report: ✅ |
Cloud Manager UI test results🎉 497 passing tests on test run #2 ↗︎
|
|
Confirmed the Longview Detail client can be navigated to locally now and also via the PR preview link. Not sure why this broke 🤔 |
hana-akamai
approved these changes
Feb 4, 2025
bnussman-akamai
approved these changes
Feb 4, 2025
bnussman-akamai
added
Approved
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 29m 37s |
| Commit |
|
| Committer | Alban Bailly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
499
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
when going to a longview client detail (and only locally) we get a
error.
Interestingly, Production is unaffected and this was not an error when rerouting the features in #11490
Changes 🔄
params.idis passed to both the base & paramsEnhancedLongviewDetailprops to satisfy reduxTarget release date 🗓️
2/11/2025
Preview 📷
How to test 🧪
Prerequisites
Note: You can start the longview service with systemctl:
sudo systemctl start longviewif nothing is happening after a while👉 following https://www.linode.com/docs/products/tools/longview/guides/troubleshooting/
Verification steps
yarn && yarn build && yarn start:manager:cito serve a build and ensure no regressionAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅