Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webengineView abnormal in DMainWindow #624

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

kegechen
Copy link
Contributor

@kegechen kegechen commented Dec 7, 2024

DPlatformWindowHandle::setWindowSurfaceType(QWindow::OpenGLSurface) needs to be called before constructing DMainWindow when use webengineview

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Dec 7, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#624
include/widgets/dplatformwindowhandle.h Outdated Show resolved Hide resolved
src/widgets/dplatformwindowhandle.cpp Outdated Show resolved Hide resolved
src/widgets/dplatformwindowhandle.cpp Outdated Show resolved Hide resolved
@kegechen kegechen force-pushed the surface_type_opengl branch from 2804e2f to 5596cf0 Compare December 7, 2024 08:27
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Dec 7, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#624
@kegechen kegechen force-pushed the surface_type_opengl branch from 5596cf0 to 92770a5 Compare December 7, 2024 08:37
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Dec 7, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#624
@kegechen kegechen force-pushed the surface_type_opengl branch from 92770a5 to 3ac78ed Compare December 9, 2024 02:33
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Dec 9, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#624
@kegechen kegechen force-pushed the surface_type_opengl branch from 3ac78ed to 5443d4e Compare December 9, 2024 03:06
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Dec 9, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#624
@kegechen kegechen requested a review from zccrs December 9, 2024 03:07
include/widgets/dplatformwindowhandle.h Outdated Show resolved Hide resolved
@kegechen kegechen force-pushed the surface_type_opengl branch from 5443d4e to 97e3d36 Compare December 9, 2024 05:09
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Dec 9, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#624
@kegechen kegechen requested a review from zccrs December 9, 2024 05:14
zccrs
zccrs previously approved these changes Dec 9, 2024
`DPlatformWindowHandle::setWindowSurfaceType(QWindow::OpenGLSurface)`
needs to be called before constructing DMainWindow when use
webengineview
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • dplatformwindowhandle.cpp文件中新增的全局变量g_surfaceType应该被声明为static,以避免潜在的命名空间污染。
  • setWindowSurfaceType函数中的g_surfaceType赋值操作没有进行任何错误检查,可能会导致非法的QWindow::SurfaceType值被设置。
  • setWindowSurfaceType函数的参数类型为int,应该明确注释说明该参数的有效值范围,以避免使用非法值。

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Dec 9, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#624
@kegechen kegechen merged commit cda1bbb into linuxdeepin:master Dec 9, 2024
19 of 21 checks passed
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen, zccrs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kegechen pushed a commit to linuxdeepin/dtk6widget that referenced this pull request Dec 9, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants