fix: resident floating message cannot be closed #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Dec 30, 2024
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#628
|
/reviewer @kegechen @18202781743 @mhduiy |
windowHandle() is not created by default, use close() instead. Bug: PMS-297669
deepin pr auto review关键摘要:
是否建议立即修改:
|
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Dec 30, 2024
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#628
18202781743
approved these changes
Dec 30, 2024
mhduiy
approved these changes
Dec 30, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy, rb-union The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
18202781743
pushed a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Jan 2, 2025
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#628
rb-union
added a commit
to rb-union/deepin-editor
that referenced
this pull request
Jan 2, 2025
See linuxdeepin/dtkwidget#628 The DFloatingMessage not trigger close() now, wait for DtkWidget integration. Log: Toast cannot be closed. Bug: https://pms.uniontech.com/bug-view-297669.html
rb-union
added a commit
to linuxdeepin/deepin-editor
that referenced
this pull request
Jan 2, 2025
See linuxdeepin/dtkwidget#628 The DFloatingMessage not trigger close() now, wait for DtkWidget integration. Log: Toast cannot be closed. Bug: https://pms.uniontech.com/bug-view-297669.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windowHandle() is not created by default,
use close() instead.
Bug: PMS-297669