Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to larger timeouts #974

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Default to larger timeouts #974

wants to merge 1 commit into from

Conversation

moratom
Copy link
Collaborator

@moratom moratom commented Mar 5, 2024

No description provided.

@moratom moratom requested a review from themarpe March 5, 2024 11:48
themarpe
themarpe reviewed Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@themarpe themarpe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should be made protocol specific (and within ETH, speed specific - after timing the initial FW upload "boot" time)

@moratom
Copy link
Collaborator Author

moratom commented Mar 6, 2024 •
edited
Loading

I think these should be made protocol specific (and within ETH, speed specific - after timing the initial FW upload "boot" time)

Makes sense yes.
I'll make sure those get in the next release to not rush this for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themarpe themarpe themarpe left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moratom @themarpe