Sync e2e tests #221
Merged
Sync e2e tests #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs to be merged after #215 |
Merged
Mohiiit
reviewed
Aug 21, 2024
crates/tests/src/lib.rs
Outdated
| self | ||
| } | ||
|
|
||
| pub fn env(mut self, args: impl IntoIterator<Item = impl Into<String>>) -> Self { |
There was a problem hiding this comment.
the function is named env but it's modifying args
apoorvsadana
approved these changes
Aug 21, 2024
.github/workflows/pull-request.yml
Outdated
Comment on lines
33
to
36
| # rust_test: | ||
| # name: Run Cargo tests | ||
| # uses: ./.github/workflows/rust-test.yml | ||
| # needs: rust_check |
There was a problem hiding this comment.
let's delete if not needed
Comment on lines
-23
to
-26
| rust_test: | ||
| name: Run Cargo tests | ||
| uses: ./.github/workflows/rust-test.yml | ||
| needs: rust_check |
.github/workflows/coverage.yml
Outdated
There was a problem hiding this comment.
what's the difference between this and rust-test.yml, do we need both?
Mohiiit
reviewed
Aug 24, 2024
Mohiiit
approved these changes
Aug 26, 2024
Coverage reportThe coverage rate is
Diff Coverage details (click to unfold)crates/node/src/main.rs
crates/node/src/service/l1.rs
|
|
🥳 🥳 🥳 ready to merge |
antiyro
approved these changes
Aug 26, 2024
akhercha
pushed a commit
to astraly-labs/madara
that referenced
this pull request
Aug 27, 2024
Co-authored-by: antiyro <[email protected]>
akhercha
pushed a commit
to astraly-labs/madara
that referenced
this pull request
Aug 27, 2024
Co-authored-by: antiyro <[email protected]>
akhercha
pushed a commit
to astraly-labs/madara
that referenced
this pull request
Aug 28, 2024
Co-authored-by: antiyro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Other information
End to end testing to sync a few blocks