Sync e2e tests

.github/workflows/coverage.yml

@@ -11,20 +11,46 @@ jobs:
     runs-on: self-hosted
     steps:
       - uses: actions/checkout@v4
-      - uses: Swatinem/rust-cache@v2
+      - uses: Swatinem/rust-cache@v2 # use a different cache key as coverae uses custom rustc args
+      - uses: dtolnay/rust-toolchain@master
         with:
-          shared-key: "cache"
-          save-if: false
+          toolchain: 1.78
       - name: Setup build deps
         run: |
           sudo apt-get update
           sudo apt-get install -y clang llvm libudev-dev protobuf-compiler
+      - uses: rui314/setup-mold@v1
       - name: Install cargo-llvm-cov
         uses: taiki-e/install-action@cargo-llvm-cov
-      - name: Coverage
-        run: cargo llvm-cov --codecov --output-path codecov.json
-      - name: Upload coverage to codecov.io
-        uses: codecov/codecov-action@v3
+
+      - uses: foundry-rs/foundry-toolchain@v1
+        with:
+          version: nightly
+      - name: Launch Anvil
+        run: anvil --fork-url $ANVIL_FORK_URL --fork-block-number $ANVIL_BLOCK_NUMBER &
+        env:
+          ANVIL_FORK_URL: "https://eth.merkle.io"
+          ANVIL_BLOCK_NUMBER: 20395662
+      - name: Wait for Anvil to be ready
+        run: |
+          while ! nc -z localhost 8545; do
+            sleep 1
+          done
+
+      - name: Build and run tests
+        run: |
+          source <(cargo llvm-cov show-env --export-prefix)
+          cargo build --bin deoxys --profile dev
+          export COVERAGE_BIN=$(realpath target/debug/deoxys)
+          rm -f target/madara-* lcov.info
+          cargo test --profile dev
+
+      - name: Generate coverage info
+        run: |
+          source <(cargo llvm-cov show-env --export-prefix)
+          cargo llvm-cov report --cobertura --output-path coverage.cobertura.xml
+
+      - name: Code Coverage Summary Report
+        uses: irongut/[email protected]
         with:
-          files: codecov.json
-          fail_ci_if_error: false
+          filename: coverage.cobertura.xml

.github/workflows/pull-request.yml

@@ -30,7 +30,12 @@ jobs:
     uses: ./.github/workflows/linters-cargo.yml
     needs: rust_check
 
-  rust_test:
-    name: Run Cargo tests
-    uses: ./.github/workflows/rust-test.yml
-    needs: rust_check
+  # rust_test:
+  #   name: Run Cargo tests
+  #   uses: ./.github/workflows/rust-test.yml
+  #   needs: rust_check
+
+  coverage:
+    name: Run Coverage
+    uses: ./.github/workflows/coverage.yml
+    needs: changelog

.github/workflows/push.yml

@@ -20,7 +20,7 @@ jobs:
     uses: ./.github/workflows/linters-cargo.yml
     needs: rust_check
 
-  rust_test:
-    name: Run Cargo tests
-    uses: ./.github/workflows/rust-test.yml
-    needs: rust_check
+  # rust_test:
+  #   name: Run Cargo tests
+  #   uses: ./.github/workflows/rust-test.yml
+  #   needs: rust_check

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Next release
 
+- tests: add e2e tests for the node
 - feat: Added l1->l2 messaging
 - test: add unitests primitives
 - tests: add tests for the rpcs endpoints

Cargo.toml

@@ -16,6 +16,7 @@ members = [
   "crates/primitives/receipt",
   "crates/primitives/state_update",
   "crates/primitives/utils",
+  "crates/tests",
 ]
 resolver = "2"
 # All previous except for `starknet-rpc-test` and `starknet-e2e-test`
@@ -36,6 +37,7 @@ default-members = [
   "crates/primitives/receipt",
   "crates/primitives/state_update",
   "crates/primitives/utils",
+  "crates/tests",
 ]
 
 [profile.dev]
@@ -106,12 +108,8 @@ cairo-lang-starknet-classes = "=2.7.0-rc.2"
 cairo-lang-utils = "=2.7.0-rc.2"
 
 alloy = { version = "0.2.0", features = [
-  "node-bindings",
-  "providers",
-  "transport-http",
-  "sol-types",
-  "json",
   "rpc-types",
+  "provider-http",
   "contract",
 ] }
 

crates/client/eth/Cargo.toml

@@ -27,7 +27,7 @@ starknet_api = { workspace = true }
 
 
 # Other
-alloy = { workspace = true, features = ["node-bindings"] }
+alloy = { workspace = true }
 anyhow = "1.0.75"
 bitvec = { workspace = true }
 blockifier = { workspace = true }

crates/client/sync/src/lib.rs

@@ -20,7 +20,6 @@ pub mod starknet_sync_worker {
     use dc_telemetry::TelemetryHandle;
     use dp_convert::ToFelt;
     use fetch::fetchers::FetchConfig;
-
     use starknet_providers::SequencerGatewayProvider;
     use std::{sync::Arc, time::Duration};
 

crates/node/src/cli/block_production.rs

@@ -1,8 +1,8 @@
-/// Parameters used to config telemetry.
+/// Parameters used to config block production.
 #[derive(Clone, Debug, clap::Parser)]
 pub struct BlockProductionParams {
     /// Disable the block production service.
     /// The block production service is only enabled with the authority (sequencer) mode.
-    #[arg(long, alias = "no-disabled")]
+    #[arg(long, alias = "no-block-production")]
     pub block_production_disabled: bool,
 }

crates/node/src/cli/mod.rs

@@ -17,6 +17,7 @@ use std::sync::Arc;
 use url::Url;
 
 #[derive(Clone, Debug, clap::Parser)]
+/// Madara: High performance Starknet sequencer/full-node.
 pub struct RunCmd {
     /// The human-readable name for this node.
     /// It is used as the network node name.

crates/node/src/service/sync.rs

@@ -51,9 +51,9 @@ impl SyncService {
                         .context("Creating ethereum client")?,
                 )
             } else {
-                return Err(anyhow::anyhow!(
-                    "❗ No L1 endpoint provided. You must provide one in order to verify the synced state."
-                ));
+                anyhow::bail!(
+                    "No Ethereum endpoint provided. You need to provide one using --l1-endpoint <RPC URL> in order to verify the synced state or disable the l1 watcher using --no-l1-sync."
+                );
             }
         } else {
             None

crates/tests/Cargo.toml

@@ -0,0 +1,21 @@
+[package]
+name = "dc-e2e-tests"
+authors.workspace = true
+homepage.workspace = true
+edition.workspace = true
+repository.workspace = true
+version.workspace = true
+license.workspace = true
+
+[dependencies]
+
+anyhow.workspace = true
+env_logger.workspace = true
+lazy_static.workspace = true
+log.workspace = true
+reqwest.workspace = true
+rstest.workspace = true
+starknet-core.workspace = true
+starknet-providers.workspace = true
+tempfile.workspace = true
+tokio = { workspace = true, features = ["rt", "macros"] }