fix(primitives): limit legacy class sizes #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchudant
force-pushed
the
class-size-limit
branch
from
0b227d7 to
05cbf8b
Compare
Trantorian1
added
bug
Trantorian1
approved these changes
Jan 10, 2025
| } | ||
| } | ||
|
|
||
| let max = u64::min(buf.len() as u64, self.limit) as usize; |
There was a problem hiding this comment.
The use of max along with the min function is a bit confusing here. I get what this does but maybe a name to_take would be clearer?
There was a problem hiding this comment.
i stole that code from the standard library, but i agree with you
Mohiiit
approved these changes
Jan 16, 2025
antiyro
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
Sending a legacy (cairo0) class with a zip-bomb in it could potentially DoS and OOM the node.
What is the new behavior?
Uncompressed size is now limited
Does this introduce a breaking change?
No