Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : create Question Mock Api #17

Merged
merged 5 commits into from
Jun 29, 2024
Merged

feat : create Question Mock Api #17

merged 5 commits into from
Jun 29, 2024

Conversation

xonmin
Copy link
Member

@xonmin xonmin commented Jun 29, 2024 •
edited
Loading

  • πŸ”€ PR 제λͺ©μ˜ ν˜•μ‹μ„ 잘 μž‘μ„±ν–ˆλ‚˜μš”? e.g. [add] pr template
  • 🧹 λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ œκ±°ν–ˆλ‚˜μš”?

μž‘μ—… λ‚΄μš©

  • ref : μ§ˆλ¬Έμ§€ κ΄€λ ¨ API Β #12
  • μ§ˆλ¬Έμ§€ 생성에 λŒ€ν•œ mock API μž‘μ„±ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • μ§€λ‚œ 번 이야기 λ‚˜λˆˆλŒ€λ‘œ entity 뢀뢄은 μš°μ„  μƒ˜ν”Œλ‘œ λ§Œλ“€λ„λ‘ ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

λΉ„κ³  (μ²¨λΆ€μžλ£Œ)

@xonmin xonmin self-assigned this Jun 29, 2024
@xonmin

This comment was marked as resolved.

Sign in to view
@xonmin xonmin marked this pull request as draft June 29, 2024 05:41
@xonmin xonmin marked this pull request as ready for review June 29, 2024 05:55
yaeoni
yaeoni reviewed Jun 29, 2024
View reviewed changes
Copy link
Collaborator

@yaeoni yaeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question은 imageId λ₯Ό λ“€κ³ μžˆκ³ , 읽기λͺ¨λΈ λ³„λ„λ‘œ λ§Œλ“€μ–΄μ„œ imageUrl 맀핑해쀄 수 있게 ν•΄μ•Όν•˜λ‚˜ 싢기도 ν•˜λ„€μš”

api/src/main/kotlin/com/mashup/dojo/QuestionController.kt
Comment on lines +20 to +22
// todo : add auth param
@Operation(summary = "create Question API", description = "μ§ˆλ¬Έμ§€ 생성")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ§ˆλ¬Έμ§€ 생성은 μ–΄λ“œλ―Ό μ„± κΈ°λŠ₯이라, authκ°€ λ³„λ„λ‘œ λ“€μ–΄κ°€μ•Όκ² λ„€μš”.
그러면 퍼블릭 API / 인터널 API prefixκ°€ 각각 λ‹€λ₯Έκ²Œ μ’‹μœΌλ €λ‚˜μš”? (λΌλŠ” 생각이 κ°‘μžκΈ° λ“€μŒ)

api/src/main/kotlin/com/mashup/dojo/QuestionController.kt Outdated
Comment on lines 23 to 25
fun createQuestion(
@Valid @RequestBody request: QuestionCreateRequest,
): DojoApiResponse<Unit> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

였 validλΌλŠ” μ–΄λ…Έν…Œμ΄μ…˜ 첨봐

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validation μ²˜λ¦¬λŠ” ν•΄λ‹Ή μ–΄λ…Έν…Œμ΄μ…˜ 말고 μ–΄λ–€ μ‹μœΌλ‘œ μ§„ν–‰ν•˜μ‹œλ‚˜μš”!??

api/src/main/kotlin/com/mashup/dojo/QuestionController.kt Outdated Show resolved Hide resolved
api/src/main/kotlin/com/mashup/dojo/dto/QuestionDto.kt Outdated Show resolved Hide resolved
service/src/main/kotlin/com/mashup/dojo/service/QuestionService.kt Outdated
Comment on lines 13 to 17
@Service
@Transactional(readOnly = true)
class QuestionService {
@Transactional
fun createQuestion(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

였 μ΄λ ‡κ²Œ μ „μ²΄μ μœΌλ‘  readOnly걸어두고 ν•„μš”ν•œ κ²½μš°μ—λ§Œ readOnlyλΉΌλŠ”κ²Œ 더 νŽΈν•˜μ‹ κ±΄κ°€μš”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사싀 μš”κ±΄ μ·¨ν–₯ μ°¨μ΄λΌμ„œ, μ»¨λ²€μ…˜λ§Œ μ •ν•˜λ©΄ 될 것 κ°™μ•„μš”!

service/src/main/kotlin/com/mashup/dojo/service/QuestionService.kt Outdated Show resolved Hide resolved
@xonmin
Copy link
Member Author

xonmin commented Jun 29, 2024

Question은 imageId λ₯Ό λ“€κ³ μžˆκ³ , 읽기λͺ¨λΈ λ³„λ„λ‘œ λ§Œλ“€μ–΄μ„œ imageUrl 맀핑해쀄 수 있게 ν•΄μ•Όν•˜λ‚˜ 싢기도 ν•˜λ„€μš”

λ…Όμ˜ μ™„ : imageId 둜 도메인 별 가지고 있기둜

@xonmin xonmin force-pushed the jeongmin/create-question-api branch from af7d68c to 49d1a46 Compare June 29, 2024 07:41
@xonmin xonmin mentioned this pull request Jun 29, 2024
Merged
2 tasks
toychip
toychip approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@toychip toychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ΅Ώκ΅Ώ κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€~~

@xonmin
Copy link
Member Author

xonmin commented Jun 29, 2024

좔가적인 λ³€κ²½ 및 λ…Όμ˜ 사항은 후속 PR μ—μ„œ μ²˜λ¦¬ν•˜λ„λ‘ ν•˜κ² μŠ΅λ‹ˆλ‹€.

@xonmin xonmin merged commit fc8302c into master Jun 29, 2024
1 check passed
@xonmin xonmin deleted the jeongmin/create-question-api branch June 29, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaeoni yaeoni yaeoni left review comments

@toychip toychip toychip approved these changes

@wonlog-g wonlog-g Awaiting requested review from wonlog-g wonlog-g is a code owner

Assignees

@xonmin xonmin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xonmin @yaeoni @toychip