-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for imathics kernel #480
Conversation
Great idea |
Done. Basically two changes: (1) the callbacks in (2) has the advantage of working with Jupyter without additional JavaScript transformations. On the other hand, in order to not break any behaviours in the classic Mathics web frontend, I added JS code to convert I'm not sure about the max_allowed_packet size, which was changed in the imathics branch. Is it something that should always be unlimited for Jupyter kernels? |
I was running into trouble with the |
Cleared my cache and it seems to be fixed now. Not sure what the problem was, half of the SVG wasn't present in the HTML document. |
Maybe the new JavaScript didn't get loaded properly. |
I strongly suggest we merge the changes necessary to run Mathics as an imathics kernel into
master
. The current imathics branch is outdated and it's a pain to keep it updated. This is a proposal to add all necessary changes to master.I've tested this with the experimental version in mathics/IMathics#11 under Jupyter 5.