mission_raw_server: make subscriptions async only #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry @jonathanreeves, I guess I made a bit of a mess. I was meaning to merge the camera PR asap but then @JonasVautherin rightfully pointed out some things in the review which meant I had to go back and fix it up. I'm just getting it to pass CI now, so hopefully I can merge it today or tomorrow and then I'll fix up your PR on top. |
|
No problem, totally understood! Mostly just glad to know I didn't misunderstand the repo states and workflows. 😆 Standing by for anything you need, just let me know if I can be helpful. |
|
No, my fault. Was too impatient. |
…omplete, and subscribe_clear_all all strictly ASYNC
julianoes
force-pushed
the
feature/revert-multiple-cameras
branch
from
5b9c6c6 to
4dcf4d7
Compare
julianoes
changed the title
julianoes
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #352 introduced breaking changes for MAVSDK main. The MAVSDK PR that would fix that is here, and has been open since august: mavlink/MAVSDK#2386. In order to be able to make changes to the submodule on MAVSDK main without requiring MAVSDK 2386 to merge, these changes will need to be reverted.