Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix live-iso serial console boot verification in e2e #2267

Merged
merged 1 commit into from
Jan 23, 2025
Merged

🐛 Fix live-iso serial console boot verification in e2e #2267

merged 1 commit into from
Jan 23, 2025

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Jan 23, 2025 •
edited
Loading

This commit:

  • Changes the target string looked for via the serial logs by the ginkgo live-iso test code to verify that the live iso image has been booted properly.
  • Removes the redundant use of the "cat" command from the boot verification process in the live-iso test
  • Changes the name of the live-iso test image to the new image that is uefi compatible.

This change is needed because the release1.8 e2e feature test are failing the live-iso boot verification even when the live-iso boot menu is visible in the serial logs.

@metal3-io-bot metal3-io-bot added this to the CAPM3 - v1.8 milestone Jan 23, 2025
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2025
@Rozzii Rozzii changed the title fix live-iso serial console boot verification 🐛 Fix live-iso serial console boot verification Jan 23, 2025
@Rozzii Rozzii changed the title 🐛 Fix live-iso serial console boot verification 🐛 Fix live-iso serial console boot verification in e2e Jan 23, 2025
@Rozzii
Copy link
Member Author

Rozzii commented Jan 23, 2025

/test metal3-centos-e2e-integration-test-release-1-8

@Rozzii Rozzii force-pushed the release1-8-live-iso-fix branch from 1e6f8ef to a192914 Compare January 23, 2025 12:29
@Rozzii
Copy link
Member Author

Rozzii commented Jan 23, 2025

/test ?

@metal3-io-bot
Copy link
Contributor

@Rozzii: The following commands are available to trigger required jobs:

/test build

/test generate

/test gomod

/test manifestlint

/test markdownlint

/test metal3-centos-e2e-integration-test-release-1-8

/test shellcheck

/test test

/test unit

The following commands are available to trigger optional jobs:

/test metal3-centos-e2e-basic-test-release-1-8

/test metal3-centos-e2e-feature-test-release-1-8-features

/test metal3-centos-e2e-feature-test-release-1-8-pivoting

/test metal3-centos-e2e-feature-test-release-1-8-remediation

/test metal3-e2e-1-29-1-30-upgrade-test-release-1-8

/test metal3-e2e-clusterctl-upgrade-test-release-1-8

/test metal3-ubuntu-e2e-basic-test-release-1-8

/test metal3-ubuntu-e2e-feature-test-release-1-8-features

/test metal3-ubuntu-e2e-feature-test-release-1-8-pivoting

/test metal3-ubuntu-e2e-feature-test-release-1-8-remediation

/test metal3-ubuntu-e2e-integration-test-release-1-8

Use /test all to run the following jobs that were automatically triggered:

build

generate

gomod

manifestlint

unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Rozzii
Copy link
Member Author

Rozzii commented Jan 23, 2025

/test metal3-centos-e2e-feature-test-release-1-8-features

@Rozzii
Copy link
Member Author

Rozzii commented Jan 23, 2025

/test metal3-centos-e2e-integration-test-release-1-8

lentzi90
lentzi90 reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2025
@Rozzii
Copy link
Member Author

Rozzii commented Jan 23, 2025

/test metal3-centos-e2e-integration-test-release-1-8
Networking flake (well known TCP/IP issue)

tuminoid
tuminoid reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

We'll rename the images in ARM to reflect this change, so it isn't as invisible and add the LIVE_ISO_IMAGE update this this PR.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2025
@Rozzii
fix live-iso serial console boot verification
c63a8ed 
This commit:
 - Changes the target string looked for via the serial logs by the ginkgo
 live-iso test code to verify that the live iso image has been booted
 properly.
 - Removes the redundant use of the "cat" command from the boot verification
 process in the live-iso test
 - Changes the name of the live-iso test image to the new image that is uefi
  compatible.

This change is needed because the release1.8 e2e feature test are failing the
live-iso boot verification even when the live-iso boot menu is visible in
the serial logs.

Signed-off-by: Adam Rozman <[email protected]>
@Rozzii Rozzii force-pushed the release1-8-live-iso-fix branch from a192914 to c63a8ed Compare January 23, 2025 13:41
@Rozzii
Copy link
Member Author

Rozzii commented Jan 23, 2025

/hold

We'll rename the images in ARM to reflect this change, so it isn't as invisible and add the LIVE_ISO_IMAGE update this this PR.

Done.

@Rozzii
Copy link
Member Author

Rozzii commented Jan 23, 2025

/test metal3-centos-e2e-integration-test-release-1-8
/test metal3-centos-e2e-feature-test-release-1-8-features

@Rozzii
Copy link
Member Author

Rozzii commented Jan 23, 2025

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2025
tuminoid
tuminoid reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This passed with test image already, so it should pass now again.
/unhold

Thanks for spotting the problem and fixing it! It was a tricky one to spot.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@tuminoid
Copy link
Member

/cherry-pick release-1.7

1.7 live-iso test breaks the same, cherry-picking there too.

@metal3-io-bot
Copy link
Contributor

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

1.7 live-iso test breaks the same, cherry-picking there too.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot merged commit feb513a into metal3-io:release-1.8 Jan 23, 2025
21 of 22 checks passed
@metal3-io-bot metal3-io-bot deleted the release1-8-live-iso-fix branch January 23, 2025 14:32
@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #2272

In response to this:

/cherry-pick release-1.7

1.7 live-iso test breaks the same, cherry-picking there too.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
CAPM3 - v1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@Rozzii @metal3-io-bot @tuminoid @lentzi90