-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix live-iso serial console boot verification in e2e #2272
🐛 Fix live-iso serial console boot verification in e2e #2272
Conversation
This commit: - Changes the target string looked for via the serial logs by the ginkgo live-iso test code to verify that the live iso image has been booted properly. - Removes the redundant use of the "cat" command from the boot verification process in the live-iso test - Changes the name of the live-iso test image to the new image that is uefi compatible. This change is needed because the release1.8 e2e feature test are failing the live-iso boot verification even when the live-iso boot menu is visible in the serial logs. Signed-off-by: Adam Rozman <[email protected]>
/test metal3-centos-e2e-integration-test-release-1-7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Just noting that running e2e-features-1-7 is not going to pass, even with the fix, as 1.7 in general is broken right now due incompatible node images. This is cherry-pick from 1.8 and is tested to work there. |
Ah, intergration test too is of course broken in 1.7. We'll wait until that is sorted out I guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
This is an automated cherry-pick of #2267
/assign tuminoid