Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix live-iso serial console boot verification in e2e #2272

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #2267

/assign tuminoid

This commit:
 - Changes the target string looked for via the serial logs by the ginkgo
 live-iso test code to verify that the live iso image has been booted
 properly.
 - Removes the redundant use of the "cat" command from the boot verification
 process in the live-iso test
 - Changes the name of the live-iso test image to the new image that is uefi
  compatible.

This change is needed because the release1.8 e2e feature test are failing the
live-iso boot verification even when the live-iso boot menu is visible in
the serial logs.

Signed-off-by: Adam Rozman <[email protected]>
@metal3-io-bot metal3-io-bot added this to the CAPM3 - v1.7 milestone Jan 23, 2025
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2025
@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-release-1-7
/retitle 🐛 Fix live-iso serial console boot verification in e2e

@metal3-io-bot metal3-io-bot changed the title [release-1.7] 🐛 Fix live-iso serial console boot verification in e2e 🐛 Fix live-iso serial console boot verification in e2e Jan 23, 2025
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2025
@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-release-1-7

Just noting that running e2e-features-1-7 is not going to pass, even with the fix, as 1.7 in general is broken right now due incompatible node images. This is cherry-pick from 1.8 and is tested to work there.

@tuminoid
Copy link
Member

Ah, intergration test too is of course broken in 1.7. We'll wait until that is sorted out I guess.

Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2025
@kashifest
Copy link
Member

/retest

@metal3-io-bot metal3-io-bot merged commit 1b8ab38 into metal3-io:release-1.7 Jan 27, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants