🌱 remove kubebuilder:default=true for CloudProviderEnabled and set defaults in defaulting webhook

[adilGhaffarDev]

What this PR does / why we need it:
Instead of using // +kubebuilder:default=true to set a default value for CloudProviderEnabled, we are configuring defaults through a defaulting webhook. This approach avoids conflicts with the NoCloudProvider field in the validation webhook.

Using kubebuilder:default makes it impossible to distinguish whether the value of CloudProviderEnabled was explicitly set by the user or automatically assigned by the default. This distinction is critical because our validation webhook ensures that CloudProviderEnabled and NoCloudProvider do not conflict when both are set. If we rely on kubebuilder:default, the validation webhook cannot function as intended, as it cannot determine the source of the CloudProviderEnabled value. By shifting defaulting logic to the webhook, we retain the ability to enforce these validation rules effectively.

This PR is a follow-up of this PR: #2108

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[Sunnatillo]

/test ?

[metal3-io-bot]

@Sunnatillo: The following commands are available to trigger required jobs:

/test build

/test generate

/test gomod

/test manifestlint

/test markdownlint

/test metal3-centos-e2e-integration-test-main

/test metal3-ubuntu-e2e-integration-test-main

/test shellcheck

/test test

/test unit

The following commands are available to trigger optional jobs:

/test metal3-centos-e2e-basic-test-main

/test metal3-centos-e2e-feature-test-main-features

/test metal3-centos-e2e-feature-test-main-pivoting

/test metal3-centos-e2e-feature-test-main-remediation

/test metal3-centos-e2e-feature-test-main-scalability

/test metal3-e2e-1-29-1-30-upgrade-test-main

/test metal3-e2e-clusterctl-upgrade-test-main

/test metal3-ubuntu-e2e-basic-test-main

/test metal3-ubuntu-e2e-feature-test-main-features

/test metal3-ubuntu-e2e-feature-test-main-pivoting

/test metal3-ubuntu-e2e-feature-test-main-remediation

Use /test all to run the following jobs that were automatically triggered:

build

generate

gomod

manifestlint

unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Sunnatillo]

/lgtm

[tuminoid]

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

[tuminoid]

Actual test need to be done via test PR in dev-env, targeting this branch.

/cc @kashifest
PTAL.

[tuminoid]

IMO this seems fine.

[elfosardo]

/approve

[kashifest]

What this PR does / why we need it: instead of setting // +kubebuilder:default=true for CloudProviderEnabled we are setting defaults in defaulting webhook. This is to avoid conflicts with NoCloudProvider.

It is still not clear to me what issue is it solving, and why the current way of setting the default using kubebuilder tag is an issue, can you describe the issue in a bit more detail ?

[adilGhaffarDev]

It is still not clear to me what issue is it solving, and why the current way of setting the default using kubebuilder tag is an issue, can you describe the issue in a bit more detail ?

i have updated the description of this PR and also the previous PR please check.

[kashifest]

i have updated the description of this PR and also the previous PR please check.

Thanks a lot. We had offline discussion as well to clear the issue out.

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kashifest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kashifest]

/retest

[tuminoid]

Needs rebase on top of #2277 after that has merged.

[tuminoid]

/lgtm

[tuminoid]

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main