-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-package] support Python 3.13 #6668
base: master
Are you sure you want to change the base?
Conversation
We'll need to wait for the rest of LightGBM's dependencies to get Python 3.13 packages on
But hey, at least We can check the state of LightGBM's dependencies here: https://conda-forge.org/status/migration/?name=python313 |
|
The conda-forge Python 3.13 migration is making progress, but looks like not all of PR to subscribe to: conda-forge/cffi-feedstock#53 |
good news: conda-forge migrations we needed for Python 3.13 appear to be done! (successful macOS Python 3.13 build) bad news: seems like conda isn't able to find a solution for our CI environment on x86_64 Python 3.9 (failed macOS x86_64 Python 3.9 build, failed Linux x86_64 Python 3.9 job Not sure about the root cause yet, will try to investigate. |
CONDA_PYTHON_REQUIREMENT="python=${PYTHON_VERSION}[build=*cpython]" | ||
# including python=version=[build=*_cp*] to ensure that conda prefers CPython and doesn't fall back to | ||
# other implementations like pypy | ||
CONDA_PYTHON_REQUIREMENT="python=${PYTHON_VERSION}[build=*_cp*]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found that changes on this line were the reason for the failures I saw in #6668 (comment).
python=3.9=*_cp*
and python=3.9[build=*_cp*]
are handled differently by conda
. I reported that at conda/conda-libmamba-solver#604, but we should just continue with the [build
form here as it does work as expected.
@@ -4,7 +4,7 @@ channels: | |||
- conda-forge | |||
dependencies: | |||
- breathe>=4.35 | |||
- python=3.10 | |||
- python=3.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm nervous about this particular change. Could you please trigger RTD build for this branch to check that everything is OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Here's a build: https://readthedocs.org/projects/lightgbm/builds/26929088/
(will check back in a bit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build failed with what looks like an internal error on readthedocs. Triggered another one: https://readthedocs.org/projects/lightgbm/builds/26929224/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build is failing repeatedly without any logs showing an issue. I tried with manually-triggered builds and builds triggered by pushing a commit here.
I've reported this to RTD: readthedocs/readthedocs.org#11949
Add support for Python 3.13, now that it's available: https://docs.python.org/3/whatsnew/3.13.html
This also proposes a new standard process for Python version upgrades in this project. Proposing that when a new Python version is generally available, we do the following:
3.10 -> 3.11
)test-old-versions
CI job (as I've done here with Python 3.8)This makes the updates easy to make and review, and reduces the risk of issues like #5969 and #6680 leading to maintenance work.