[python-package] support Python 3.13 #6668
+45
−36
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ on: | |
| env: | ||
| COMPILER: gcc | ||
| OS_NAME: 'linux' | ||
| PYTHON_VERSION: '3.13' | ||
| TASK: 'check-links' | ||
|
|
||
| jobs: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,32 +28,32 @@ jobs: | |
| include: | ||
| - os: macos-13 | ||
| task: regular | ||
| python_version: '3.11' | ||
| - os: macos-13 | ||
| task: sdist | ||
| python_version: '3.12' | ||
| - os: macos-13 | ||
| task: bdist | ||
| python_version: '3.9' | ||
| - os: macos-13 | ||
| task: if-else | ||
| python_version: '3.10' | ||
| - os: macos-14 | ||
| task: bdist | ||
| method: wheel | ||
| python_version: '3.11' | ||
| - os: macos-13 | ||
| task: mpi | ||
| method: source | ||
| python_version: '3.12' | ||
| - os: macos-13 | ||
| task: mpi | ||
| method: pip | ||
| python_version: '3.13' | ||
| - os: macos-13 | ||
| task: mpi | ||
| method: wheel | ||
| python_version: '3.10' | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
@@ -113,12 +113,19 @@ jobs: | |
| --rm \ | ||
| -v $(pwd):/opt/lgb-build \ | ||
| -w /opt/lgb-build \ | ||
| python:3.13 \ | ||
| /bin/bash ./.ci/test-python-latest.sh | ||
| test-old-versions: | ||
| name: Python - oldest supported versions (ubuntu-latest) | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 60 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| # end-of-life Python versions | ||
| python_version: | ||
| - 3.7 | ||
| - 3.8 | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
@@ -140,12 +147,12 @@ jobs: | |
| --rm \ | ||
| -v $(pwd):/opt/lgb-build \ | ||
| -w /opt/lgb-build \ | ||
| python:${{ matrix.python_version }} \ | ||
| /bin/bash ./.ci/test-python-oldest.sh | ||
| all-python-package-jobs-successful: | ||
| if: always() | ||
| runs-on: ubuntu-latest | ||
| needs: [test, test-latest-versions, test-old-versions] | ||
| steps: | ||
| - name: Note that all tests succeeded | ||
| uses: re-actors/[email protected] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ env: | |
| COMPILER: 'gcc' | ||
| MAKEFLAGS: '-j4' | ||
| OS_NAME: 'linux' | ||
| PYTHON_VERSION: '3.13' | ||
|
|
||
| jobs: | ||
| test: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ channels: | |
| - conda-forge | ||
| dependencies: | ||
| - breathe>=4.35 | ||
| - python=3.11 | ||
|
There was a problem hiding this comment. I'm nervous about this particular change. Could you please trigger RTD build for this branch to check that everything is OK? There was a problem hiding this comment. Sure! Here's a build: https://readthedocs.org/projects/lightgbm/builds/26929088/ (will check back in a bit) There was a problem hiding this comment. The build failed with what looks like an internal error on readthedocs. Triggered another one: https://readthedocs.org/projects/lightgbm/builds/26929224/ There was a problem hiding this comment. The build is failing repeatedly without any logs showing an issue. I tried with manually-triggered builds and builds triggered by pushing a commit here. I've reported this to RTD: readthedocs/readthedocs.org#11949 |
||
| - r-base=4.3.2 | ||
| - r-data.table=1.14.10 | ||
| - r-jsonlite=1.8.8 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found that changes on this line were the reason for the failures I saw in #6668 (comment).
python=3.9=*_cp*andpython=3.9[build=*_cp*]are handled differently byconda. I reported that at conda/conda-libmamba-solver#604, but we should just continue with the[buildform here as it does work as expected.