-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export Performance Improvement - Addresses #5615 #5629
Conversation
I didn't check every and each resource, but from what I could tell, it all looks great. @niwamo Is there a specific reason that the Intune resources were not included? Just asking, I would take it up on myself to implement your changes in them as well. I know some pitfalls there from properties that would be missing (e.g. script content that is only available when fetching a single resource). |
No specific reason. For this PR, I focused on resources that I personally want to export, and I do not have a use case for the Intune modules. |
@niwamo Alright, I'll add the changes to the Intune resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request (PR) description
Implements the changes described in #5615
I apologize in advance for the huge PR.
Tagging @FabienTschanz due to his expressed interest.
This Pull Request (PR) fixes the following issues
Implements the changes described in #5615
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).