mitigating onnx install issue #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interesaaat
approved these changes
Aug 2, 2024
ksaur
commented
Aug 5, 2024
| @@ -138,19 +138,19 @@ jobs: | |||
| cd ~/work/hummingbird/tvm/python | |||
| python3 -m pip install -e . | |||
|
|
|||
| # We don't run pytest for macos py3.9 since we do coverage for that case. | |||
| # We don't run pytest for ubuntu py3.9 since we do coverage for that case. | |||
There was a problem hiding this comment.
Now there is some problem with macos + codecov that is blocking the pipeline. Changing this to unblock, and also since mac is slowest it makes no sense to make it worse! Will fix additional issues in separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #788 (stop gap, does not close)