Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitigating onnx install issue #789

Merged
merged 3 commits into from
Aug 5, 2024
Merged

mitigating onnx install issue #789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae04978
testing onnx issue
ksaur Aug 2, 2024
ebddc21
codecov prob for macs, moving to ubu
ksaur Aug 5, 2024
47e18fd
Update pythonapp.yml
ksaur Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/pythonapp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,19 +138,19 @@ jobs:
cd ~/work/hummingbird/tvm/python
python3 -m pip install -e .

# We don't run pytest for macos py3.9 since we do coverage for that case.
# We don't run pytest for ubuntu py3.9 since we do coverage for that case.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now there is some problem with macos + codecov that is blocking the pipeline. Changing this to unblock, and also since mac is slowest it makes no sense to make it worse! Will fix additional issues in separate PR.

- name: Test with pytest
if: ${{ matrix.python-version != '3.9' || startsWith(matrix.os, 'macos') != true }}
if: ${{ matrix.python-version != '3.9' || startsWith(matrix.os, 'ubuntu') != true }}
run: pytest
# Run and push coverage only for macos py3.9
- name: Coverage 3.9 macos
if: ${{ matrix.python-version == '3.9' && startsWith(matrix.os, 'macos') }}
# Run and push coverage only for ubuntu py3.9
- name: Coverage 3.9 ubuntu
if: ${{ matrix.python-version == '3.9' && startsWith(matrix.os, 'ubuntu') }}
run: |
coverage run -a -m pytest tests
coverage xml
- name: Upload coverage to Codecov
if: ${{ matrix.python-version == '3.9' && startsWith(matrix.os, 'macos') }}
uses: codecov/codecov-action@v3
if: ${{ matrix.python-version == '3.9' && startsWith(matrix.os, 'ubuntu') }}
uses: codecov/codecov-action@v4
with:
file: ./coverage.xml
flags: unittests
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
install_requires = [
"numpy>=1.15",
"onnxconverter-common>=1.6.0",
"onnx<=1.16.1",
"scipy",
"scikit-learn",
"torch>1.7.0",
Expand Down
Loading