-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XDF to "Reading EEG data" tutorial #9289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, three nitpicks
Co-authored-by: Stefan Appelhoff <[email protected]>
Co-authored-by: Stefan Appelhoff <[email protected]>
Any idea why CircleCI is not showing up? |
No idea, it doesn't show up in https://app.circleci.com/pipelines/github/mne-tools/mne-python and even when I try to force it using https://app.circleci.com/pipelines/github/mne-tools/mne-python?branch=pull%2F9289 it doesn't show up. Sometimes in the past CircleCI has had problems when people forked and then enabled builds on their fork, did you mess with any of your own GitHub user's CircleCI settings recently? |
Hm, maybe I changed some CircleCI setting accidentally when I was cleaning out (supposedly) unused apps. Do you know where I need to look? |
I have CircleCI listed in "Authorized OAuth Apps" in https://github.com/settings/applications. Also you can try navigating to something like https://app.circleci.com/pipelines/github/mne-tools/mne-python/7809/workflows/d85b7b1f-5a4f-4193-bd35-68d6b582e243/jobs/27188/artifacts, I think CircleCI only lets you do it if you have given it some permissions. |
I didn't have CircleCI in my list of authorized apps. Following the link did prompt me to log in, which in turn created the entry again. Thanks @larsoner! I'll create some dummy commit to trigger the build. |
@drammock not directly related to this PR, but the TOC link "Setting EEG references" never gets highlighted (not even if I click on it). Maybe it's because the corresponding text is too little, but I think it would be nice if it highlighted at least when clicking it. Edit: clicking on the various entries in the TOC seems broken, not just the link I mentioned. Clicking some links takes me to a different section. |
Co-authored-by: Daniel McCloy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this tiny proof-of-concept example:
- https://27538-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/io/plot_20_reading_eeg_data.html#xdf-data-xdf-xdfz
- https://27538-1301584-gh.circle-artifacts.com/0/dev/auto_examples/io/plot_read_xdf.html
+1 for merge from me
@drammock can you see if you're happy with the structure now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than 2 small details LGTM
Co-authored-by: Daniel McCloy <[email protected]>
Thanks @cbrnr ! |
* upstream/main: Add XDF to "Reading EEG data" tutorial (mne-tools#9289)
Closes #5180.
Besides tidying up and improving the docstring a bit, I have added a section on how to import XDF data.