Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XDF to "Reading EEG data" tutorial #9289

Merged
merged 12 commits into from
Apr 20, 2021
Merged

Conversation

cbrnr
Copy link
Contributor

@cbrnr cbrnr commented Apr 13, 2021

Closes #5180.

Besides tidying up and improving the docstring a bit, I have added a section on how to import XDF data.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, three nitpicks

tutorials/io/plot_20_reading_eeg_data.py Outdated Show resolved Hide resolved
tutorials/io/plot_20_reading_eeg_data.py Outdated Show resolved Hide resolved
tutorials/io/plot_20_reading_eeg_data.py Outdated Show resolved Hide resolved
@cbrnr
Copy link
Contributor Author

cbrnr commented Apr 13, 2021

Any idea why CircleCI is not showing up?

@cbrnr cbrnr added the DOC label Apr 13, 2021
@larsoner
Copy link
Member

No idea, it doesn't show up in https://app.circleci.com/pipelines/github/mne-tools/mne-python and even when I try to force it using https://app.circleci.com/pipelines/github/mne-tools/mne-python?branch=pull%2F9289 it doesn't show up. Sometimes in the past CircleCI has had problems when people forked and then enabled builds on their fork, did you mess with any of your own GitHub user's CircleCI settings recently?

@cbrnr
Copy link
Contributor Author

cbrnr commented Apr 13, 2021

Hm, maybe I changed some CircleCI setting accidentally when I was cleaning out (supposedly) unused apps. Do you know where I need to look?

@larsoner
Copy link
Member

I have CircleCI listed in "Authorized OAuth Apps" in https://github.com/settings/applications. Also you can try navigating to something like https://app.circleci.com/pipelines/github/mne-tools/mne-python/7809/workflows/d85b7b1f-5a4f-4193-bd35-68d6b582e243/jobs/27188/artifacts, I think CircleCI only lets you do it if you have given it some permissions.

@cbrnr
Copy link
Contributor Author

cbrnr commented Apr 13, 2021

I didn't have CircleCI in my list of authorized apps. Following the link did prompt me to log in, which in turn created the entry again. Thanks @larsoner! I'll create some dummy commit to trigger the build.

@cbrnr
Copy link
Contributor Author

cbrnr commented Apr 13, 2021

@cbrnr
Copy link
Contributor Author

cbrnr commented Apr 13, 2021

@drammock not directly related to this PR, but the TOC link "Setting EEG references" never gets highlighted (not even if I click on it). Maybe it's because the corresponding text is too little, but I think it would be nice if it highlighted at least when clicking it.

Edit: clicking on the various entries in the TOC seems broken, not just the link I mentioned. Clicking some links takes me to a different section.

tutorials/io/plot_20_reading_eeg_data.py Outdated Show resolved Hide resolved
tutorials/io/plot_20_reading_eeg_data.py Outdated Show resolved Hide resolved
Co-authored-by: Daniel McCloy <[email protected]>
@cbrnr cbrnr mentioned this pull request Apr 14, 2021
@cbrnr cbrnr added this to the 0.23 milestone Apr 19, 2021
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larsoner
Copy link
Member

@drammock can you see if you're happy with the structure now?

Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than 2 small details LGTM

examples/io/plot_read_xdf.py Outdated Show resolved Hide resolved
doc/references.bib Outdated Show resolved Hide resolved
@larsoner larsoner merged commit c5b1297 into mne-tools:main Apr 20, 2021
@larsoner
Copy link
Member

Thanks @cbrnr !

larsoner added a commit to larsoner/mne-python that referenced this pull request Apr 20, 2021
* upstream/main:
  Add XDF to "Reading EEG data" tutorial (mne-tools#9289)
@cbrnr cbrnr deleted the tut-eeg-xdf branch June 17, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for XDF (labstreaminglayer format)
4 participants