Siam border decision oddities when Johor is involved (event 97123) #73
Assignees
Labels
bug
Something isn't working
Comments
rogerburks
added a commit
that referenced
this issue
Feb 14, 2022
References #70 and #73. In many cases, the cores of tags that start uncivilized are removed by decisions and events that are meant to simulate historical change from uncivlized areas to colonies to post-colonial areas. However, if cores are considered to be claims, this should not occur while the tag still exists. This is different from a situation where tags give up cores in treaties, when this fix should not be applied. Additionally, I have allowed core removal in cases where the tag no longer exists, so that the simulation occurs as intended. I have ignored removal of ENG cores in the New World, since those should happen always through ENG giving up cores voluntarily. In other cases, especially within Europe, it seemed like a bad idea to change anything. In the course of making changes, I removed `cleanup_colonial_cores`, since that decision should not exist if things function as intended. I changed `organize_ghana` and `reorganize_ghana` to require a tag to own the in-game capital of Ashanti, since core removals were not working while Ashanti and other tags with claims on Ghana existed. This seemed justifiable to me since otherwise only a single coastal province was required to organize all of Ghana. I removed a few apparently arbitrary Malay core changes in `97122`, `Anglo-Siamese Treaty of 1909`, because it did not make sense to switch around and not remove the claims of tags that do not exist. I additionally made some changes to add Malaysia cores properly to its provinces. The initial set of changes succeeded with only a few noticed bugs. These and matters requiring investigation are listed and discussed [in this post](#70 (comment)). Found an overlooked core removal of potentially existing Kurdish tags.
rogerburks
added a commit
that referenced
this issue
Feb 17, 2022
References #70 and #73. In many cases, the cores of tags that start uncivilized are removed by decisions and events that are meant to simulate historical change from uncivlized areas to colonies to post-colonial areas. However, if cores are considered to be claims, this should not occur while the tag still exists. This is different from a situation where tags give up cores in treaties, when this fix should not be applied. Additionally, I have allowed core removal in cases where the tag no longer exists, so that the simulation occurs as intended. I have ignored removal of ENG cores in the New World, since those should happen always through ENG giving up cores voluntarily. In other cases, especially within Europe, it seemed like a bad idea to change anything. In the course of making changes, I removed `cleanup_colonial_cores`, since that decision should not exist if things function as intended. I changed `organize_ghana` and `reorganize_ghana` to require a tag to own the in-game capital of Ashanti, since core removals were not working while Ashanti and other tags with claims on Ghana existed. This seemed justifiable to me since otherwise only a single coastal province was required to organize all of Ghana. I removed a few apparently arbitrary Malay core changes in `97122`, `Anglo-Siamese Treaty of 1909`, because it did not make sense to switch around and not remove the claims of tags that do not exist. I additionally made some changes to add Malaysia cores properly to its provinces. The initial set of changes succeeded with only a few noticed bugs. These and matters requiring investigation are listed and discussed [in this post](#70 (comment)). Found an overlooked core removal of potentially existing Kurdish tags. Acadia core removal now removes the cores on Maritime Union territory as well. Louisiana core removal now covers the possibility of USA core removal.
rogerburks
added a commit
that referenced
this issue
Feb 17, 2022
References #70 and #73. In many cases, the cores of tags that start uncivilized are removed by decisions and events that are meant to simulate historical change from uncivlized areas to colonies to post-colonial areas. However, if cores are considered to be claims, this should not occur while the tag still exists. This is different from a situation where tags give up cores in treaties, when this fix should not be applied. Additionally, I have allowed core removal in cases where the tag no longer exists, so that the simulation occurs as intended. I have ignored removal of ENG cores in the New World, since those should happen always through ENG giving up cores voluntarily. In other cases, especially within Europe, it seemed like a bad idea to change anything. In the course of making changes, I removed `cleanup_colonial_cores`, since that decision should not exist if things function as intended. I changed `organize_ghana` and `reorganize_ghana` to require a tag to own the in-game capital of Ashanti, since core removals were not working while Ashanti and other tags with claims on Ghana existed. This seemed justifiable to me since otherwise only a single coastal province was required to organize all of Ghana. I removed a few apparently arbitrary Malay core changes in `97122`, `Anglo-Siamese Treaty of 1909`, because it did not make sense to switch around and not remove the claims of tags that do not exist. I additionally made some changes to add Malaysia cores properly to its provinces. The initial set of changes succeeded with only a few noticed bugs. These and matters requiring investigation are listed and discussed [in this post](#70 (comment)). Found an overlooked core removal of potentially existing Kurdish tags. Acadia core removal now removes the cores on Maritime Union territory as well. Louisiana core removal now covers the possibility of USA core removal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Event 97123, the resolution of the Anglo-Siamese Border Treaty of 1909, undergoes some probably unintended oddities when the UK is not involved. Most especially when Johor initiates the treaty, some of Johor's own cores are removed from some provinces that it acquires or already had, if Siam agrees:
https://github.com/moretrim/PFH/blob/62468472983d23bdee746663c61c512aa00aae59/PFH/events/East%20Indies.txt#L932-L943
When it does proceed as intended, Perak and Pahang cores are added to provinces that did not previously have them. In the actual treaty, the acquired areas were added to the Unfederated Malay States, which also included Johor further south. Perak and Pahang were part of the Federated Malay States. This arrangement existed until the end of World War II. (image from wikipedia):
The game deals with these complications by eventually absorbing the whole area into the United Kingdom without an intermediate tag, then allows the formation of an essentially modern Malaysia once all that is done. It was therefore likely not expected that Johor would be reacquiring all of its cores during the course of the game. The addition of cores for Perak or Pahang to certain provinces is possibly to keep some kind of Malay cores on these provinces after Johor is expected to have gone away in the game.
I believe that I understand the point of adding the cores, but it seems more elegant to preserve the Johor cores instead, and remove them only if Malaysia is formed:
https://github.com/moretrim/PFH/blob/55e4b1520faeaa07c0161cc1204aebe0b1a62b2a/PFH/events/East%20Indies.txt#L932-L956
One additional thing could be done when Johor does not initiate the treaty, which is to add cores of Perak and Pahang as in the original event, so that these tags are not nerfed. This option is in testing, and needs some overhaul to result in some syntax that will work.
The text was updated successfully, but these errors were encountered: