Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent core removal for existing tags in most cases #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rogerburks
Copy link
Collaborator

References #70 and #73. In many cases, the cores of tags that start uncivilized are removed by decisions and events that are meant to simulate historical change from uncivilized areas to colonies to post-colonial areas. However, if cores are considered to be claims, this should arguably not occur under many conditions while the tag still exists. Gameplay of a large number of tags is affected, including most tags from Africa, Malaysia, and Indonesia. Rupert's Land, Louisiana, and Acadia are civilized tags that are also affected.

The core removal method that I chose is a little longer than the usual method, but it has worked in all tests to remove cores only and precisely when and how I wanted:

any_country = {
limit = {
tag = AGC
exists = no
}
all_core = {
limit = {
is_core = MOZ
}
remove_core = AGC
}
}

An exception where core removal seems justified, is when tags give up cores in treaties and through other agreements. Under those circumstances, this fix is not applied. Additionally, I have allowed core removal in cases where the tag no longer exists, such that simulated historical change occurs as intended. I have ignored removal of ENG cores in the New World, since those should happen always through ENG giving up cores voluntarily. In other cases, especially within Europe, it seemed like a bad idea to change anything.

In the course of making changes, I removed cleanup_colonial_cores, since that decision should not exist if core removal functions as intended.

I changed organize_ghana and reorganize_ghana to require a tag to own the in-game capital of Ashanti, since core removals were not working while Ashanti and other tags with claims on Ghana existed. This seemed justifiable to me since otherwise only a single coastal province was required to organize all of Ghana.

I removed a few apparently arbitrary Malay core changes in 97122, Anglo-Siamese Treaty of 1909, because it did not make sense to switch around and not remove the claims of tags that do not exist. I additionally made some changes to add Malaysia cores properly to its provinces.

The initial set of changes succeeded with only a few noticed bugs. These and matters requiring investigation are listed and discussed in this post.

@rogerburks rogerburks self-assigned this Feb 14, 2022
@rogerburks rogerburks requested a review from moretrim February 14, 2022 12:05
@rogerburks rogerburks added the bug Something isn't working label Feb 14, 2022
@rogerburks rogerburks force-pushed the rbx4/CoreRemovalExistingColonialTagFix branch from 8d97168 to 19bbaa5 Compare February 17, 2022 08:32
References #70 and #73. In many cases, the cores of tags that start uncivilized are removed by decisions and events that are meant to simulate historical change from uncivlized areas to colonies to post-colonial areas. However, if cores are considered to be claims, this should not occur while the tag still exists. This is different from a situation where tags give up cores in treaties, when this fix should not be applied. Additionally, I have allowed core removal in cases where the tag no longer exists, so that the simulation occurs as intended. I have ignored removal of ENG cores in the New World, since those should happen always through ENG giving up cores voluntarily. In other cases, especially within Europe, it seemed like a bad idea to change anything.

In the course of making changes, I removed `cleanup_colonial_cores`, since that decision should not exist if things function as intended.

I changed `organize_ghana` and `reorganize_ghana` to require a tag to own the in-game capital of Ashanti, since core removals were not working while Ashanti and other tags with claims on Ghana existed. This seemed justifiable to me since otherwise only a single coastal province was required to organize all of Ghana.

I removed a few apparently arbitrary Malay core changes in `97122`, `Anglo-Siamese Treaty of 1909`, because it did not make sense to switch around and not remove the claims of tags that do not exist. I additionally made some changes to add Malaysia cores properly to its provinces.

The initial set of changes succeeded with only a few noticed bugs. These and matters requiring investigation are listed and discussed [in this post](#70 (comment)).

Found an overlooked core removal of potentially existing Kurdish tags.

Acadia core removal now removes the cores on Maritime Union territory as well. Louisiana core removal now covers the possibility of USA core removal.
@rogerburks rogerburks force-pushed the rbx4/CoreRemovalExistingColonialTagFix branch from ebd7002 to 0107dbc Compare February 17, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant