-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add velocity and acceleration scaling when using custom limits in Time Parameterization #1832
Conversation
…ime parameterization
Codecov ReportBase: 50.46% // Head: 50.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1832 +/- ##
==========================================
- Coverage 50.46% 50.39% -0.06%
==========================================
Files 374 374
Lines 31335 31363 +28
==========================================
- Hits 15809 15803 -6
- Misses 15526 15560 +34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
54eba67
to
b073888
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes! I think this looks good in general. Just out of curiosity, is your work with the Hybrid Planner and dynamic joint limits open source?
moveit_core/trajectory_processing/src/time_optimal_trajectory_generation.cpp
Outdated
Show resolved
Hide resolved
moveit_core/trajectory_processing/src/time_optimal_trajectory_generation.cpp
Outdated
Show resolved
Hide resolved
moveit_core/trajectory_processing/include/moveit/trajectory_processing/time_parameterization.h
Show resolved
Hide resolved
moveit_core/trajectory_processing/src/time_optimal_trajectory_generation.cpp
Outdated
Show resolved
Hide resolved
...jectory_processing/include/moveit/trajectory_processing/time_optimal_trajectory_generation.h
Show resolved
Hide resolved
moveit_core/trajectory_processing/include/moveit/trajectory_processing/ruckig_traj_smoothing.h
Show resolved
Hide resolved
Yep! I have it all available on my forks. I have implemented the changes across MoveIt, MTC, and moveit_msgs with some help from @AndyZe. It's just a matter of creating modular PRs to the relevant repos to get it all integrated. |
...jectory_processing/include/moveit/trajectory_processing/time_optimal_trajectory_generation.h
Outdated
Show resolved
Hide resolved
moveit_core/trajectory_processing/src/time_optimal_trajectory_generation.cpp
Outdated
Show resolved
Hide resolved
moveit_core/trajectory_processing/src/time_optimal_trajectory_generation.cpp
Outdated
Show resolved
Hide resolved
moveit_core/trajectory_processing/src/time_optimal_trajectory_generation.cpp
Show resolved
Hide resolved
moveit_core/trajectory_processing/src/time_optimal_trajectory_generation.cpp
Outdated
Show resolved
Hide resolved
moveit_core/trajectory_processing/src/time_optimal_trajectory_generation.cpp
Outdated
Show resolved
Hide resolved
moveit_core/trajectory_processing/src/time_optimal_trajectory_generation.cpp
Outdated
Show resolved
Hide resolved
moveit_core/trajectory_processing/src/time_optimal_trajectory_generation.cpp
Outdated
Show resolved
Hide resolved
Thanks for the PR @mechwiz ! |
7baf50d
to
b5d774e
Compare
Description
In an effort to use dynamic joint velocity, acceleration, or jerk limits it was mentioned by @henningkayser in my moveit_msgs PR here moveit/moveit_msgs#144 (comment) that scaling should be applied regardless if using default limits or custom limits. This PR creates the necessary changes to accomplish this.
@AndyZe
EDIT
This PR also adds another overloaded
computeTimeStamps
function for passing in a vector of JointLimit messages. I found this to be easier to work with in my implementation for integrating dynamic joint limits.Checklist