Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chomp depend, closes #3228 #3229

Merged
merged 1 commit into from
Jan 12, 2025
Merged

fix chomp depend, closes #3228 #3229

merged 1 commit into from
Jan 12, 2025

Conversation

mikeferguson
Copy link
Contributor

Description

moveit_planners_chomp depends on chomp_motion_planner - both are needed - I missed that in #3015

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mikeferguson mikeferguson changed the title fix chomp include, closes #3228 fix chomp depend, closes #3228 Jan 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.01%. Comparing base (2566467) to head (a08aa3d).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3229      +/-   ##
==========================================
+ Coverage   45.66%   46.01%   +0.35%     
==========================================
  Files         714      714              
  Lines       62296    62315      +19     
  Branches     7531     7531              
==========================================
+ Hits        28444    28666     +222     
+ Misses      33685    33482     -203     
  Partials      167      167              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JafarAbdi JafarAbdi added this pull request to the merge queue Jan 12, 2025
@sea-bass sea-bass added backport-humble Mergify label that triggers a PR backport to Humble backport-jazzy Mergify label that triggers a PR backport to Jazzy labels Jan 12, 2025
Merged via the queue into main with commit 9e0b4dd Jan 12, 2025
12 checks passed
@JafarAbdi JafarAbdi deleted the fix_chomp_include branch January 12, 2025 02:32
mergify bot pushed a commit that referenced this pull request Jan 12, 2025
(cherry picked from commit 9e0b4dd)

# Conflicts:
#	moveit_planners/moveit_planners/package.xml
mergify bot pushed a commit that referenced this pull request Jan 12, 2025
(cherry picked from commit 9e0b4dd)
sea-bass pushed a commit that referenced this pull request Jan 12, 2025
(cherry picked from commit 9e0b4dd)

Co-authored-by: Michael Ferguson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble backport-jazzy Mergify label that triggers a PR backport to Jazzy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants