Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-11009 - [Toolbar Redesign] One tap new tab doesn't open a new tab when custom homepage url is set (backport #24056) #24058

Open
wants to merge 1 commit into
base: release/v134
Choose a base branch
from
Open

Bugfix FXIOS-11009 - [Toolbar Redesign] One tap new tab doesn't open a new tab when custom homepage url is set (backport #24056) #24058

wants to merge 1 commit into from
+2 −1

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 9, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)
This is an automatic backport of pull request #24056 done by [Mergify](https://mergify.com).

@PARAIPAN9 @mergify
Bugfix FXIOS-11009 - [Toolbar Redesign] One tap new tab doesn't open …
702479b 
…a new tab when custom homepage url is set (#24056)

Open new tab when custom url is set.

(cherry picked from commit 548c1af)
@mergify mergify bot requested a review from a team as a code owner January 9, 2025 16:02
@mergify mergify bot requested review from MattLichtenstein and removed request for a team January 9, 2025 16:02
@mergify mergify bot mentioned this pull request Jan 9, 2025
Merged
6 tasks
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 32.8%
📖 Edited 2 files
📖 Created 0 files

Client.app: Coverage: 31.59

File Coverage
BrowserViewController.swift 4.76% ⚠️
PrivilegedRequest.swift 79.31% ✅

WidgetKitExtension.appex: Coverage: 18.03

File Coverage
PrivilegedRequest.swift 79.31% ✅

Generated by 🚫 Danger Swift against 702479b

@PARAIPAN9 PARAIPAN9 self-requested a review January 9, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PARAIPAN9 PARAIPAN9 PARAIPAN9 approved these changes

@MattLichtenstein MattLichtenstein Awaiting requested review from MattLichtenstein MattLichtenstein is a code owner automatically assigned from mozilla-mobile/fxios-eng

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mobiletest-ci-bot @PARAIPAN9