-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix FXIOS-11009 - [Toolbar Redesign] One tap new tab doesn't open a new tab when custom homepage url is set #24056
Merged
PARAIPAN9
merged 1 commit into
main
from
sparaipan/fxios-11009-One-tap-new-tab-does-not-open-a-new-tab-when-custom-homepage-url-is-set
Jan 9, 2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client.app: Coverage: 32.4
WidgetKitExtension.appex: Coverage: 7.07
Generated by 🚫 Danger Swift against 46bd818 |
@Mergifyio backport release/v134 |
✅ Backports have been created
|
MattLichtenstein
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
PARAIPAN9
deleted the
sparaipan/fxios-11009-One-tap-new-tab-does-not-open-a-new-tab-when-custom-homepage-url-is-set
branch
January 9, 2025 16:01
6 tasks
pascalchevrel
pushed a commit
that referenced
this pull request
Jan 13, 2025
…a new tab when custom homepage url is set (backport #24056) (#24058) Bugfix FXIOS-11009 - [Toolbar Redesign] One tap new tab doesn't open a new tab when custom homepage url is set (#24056) Open new tab when custom url is set. (cherry picked from commit 548c1af) Co-authored-by: PARAIPAN SORIN <[email protected]>
mdotb-moz
pushed a commit
that referenced
this pull request
Jan 14, 2025
…a new tab when custom homepage url is set (backport #24056) (#24058) Bugfix FXIOS-11009 - [Toolbar Redesign] One tap new tab doesn't open a new tab when custom homepage url is set (#24056) Open new tab when custom url is set. (cherry picked from commit 548c1af) Co-authored-by: PARAIPAN SORIN <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)