Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-11009 - [Toolbar Redesign] One tap new tab doesn't open a new tab when custom homepage url is set #24056

Conversation

PARAIPAN9
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 commented Jan 9, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@PARAIPAN9 PARAIPAN9 requested a review from a team as a code owner January 9, 2025 11:34
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 34.06%
📖 Edited 2 files
📖 Created 0 files

Client.app: Coverage: 32.4

File Coverage
BrowserViewController.swift 3.46% ⚠️
PrivilegedRequest.swift 79.31%

WidgetKitExtension.appex: Coverage: 7.07

File Coverage
PrivilegedRequest.swift 79.31%

Generated by 🚫 Danger Swift against 46bd818

@PARAIPAN9
Copy link
Collaborator Author

@Mergifyio backport release/v134

Copy link
Contributor

mergify bot commented Jan 9, 2025

backport release/v134

✅ Backports have been created

Copy link
Collaborator

@MattLichtenstein MattLichtenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@PARAIPAN9 PARAIPAN9 merged commit 548c1af into main Jan 9, 2025
10 checks passed
@PARAIPAN9 PARAIPAN9 deleted the sparaipan/fxios-11009-One-tap-new-tab-does-not-open-a-new-tab-when-custom-homepage-url-is-set branch January 9, 2025 16:01
mergify bot pushed a commit that referenced this pull request Jan 9, 2025
…a new tab when custom homepage url is set (#24056)

Open new tab when custom url is set.

(cherry picked from commit 548c1af)
pascalchevrel pushed a commit that referenced this pull request Jan 13, 2025
…a new tab when custom homepage url is set (backport #24056) (#24058)

Bugfix FXIOS-11009 - [Toolbar Redesign]  One tap new tab doesn't open a new tab when custom homepage url is set (#24056)

Open new tab when custom url is set.

(cherry picked from commit 548c1af)

Co-authored-by: PARAIPAN SORIN <[email protected]>
mdotb-moz pushed a commit that referenced this pull request Jan 14, 2025
…a new tab when custom homepage url is set (backport #24056) (#24058)

Bugfix FXIOS-11009 - [Toolbar Redesign]  One tap new tab doesn't open a new tab when custom homepage url is set (#24056)

Open new tab when custom url is set.

(cherry picked from commit 548c1af)

Co-authored-by: PARAIPAN SORIN <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants