SplitTunnel 01: Use a factory for creation #9889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strseb
force-pushed
the
strseb/stack/1
branch
from
2d82dfe to
8521997
Compare
strseb
force-pushed
the
strseb/stack/2
branch
from
52e42f9 to
606671c
Compare
This was referenced Sep 19, 2024
oskirby
reviewed
Sep 19, 2024
| MZ_COUNT_CTOR(WindowsDaemon); | ||
|
|
||
| m_firewallManager = WindowsFirewall::instance(); |
There was a problem hiding this comment.
Minor nit: Perhaps we could make this WindowsFirewall::create() or just new WindowsFirewall(this) to make its initialization call explicit and consistent with the rest of the stuff here (and establish an obvious object ownership hierarchy).
oskirby
reviewed
Sep 19, 2024
| } | ||
| // 04: Make sure the Windows Firewall has created the sublayer | ||
| // otherwise the driver will fail to initialize | ||
| if (!fw || !fw->init()) { |
There was a problem hiding this comment.
Minor nit: I get that this hasn't really changed, but it is kindof odd for the firewall init to be happening here. It would be a little more appropriate for WindowsDaemon to do the init, and then pass in a reference to the WFP sublayer as an argument to WindowsSplitTunnel::create()
There was a problem hiding this comment.
How exactly does the split tunnel driver figure out the WFP sublayer to use?
There was a problem hiding this comment.
The Sublayer is hardcoded in the driver...
oskirby
approved these changes
Sep 19, 2024
strseb
force-pushed
the
strseb/stack/2
branch
from
606671c to
018ea7a
Compare
Currently you need to create the object and then call the correct functions in order to have an initialized object. Similar to wgnt lets make sure that no "invalid" object can even exist. so that we can assert you will not call i.e. start() on a closed handle. Given that it's not cool to have constructors throw exceptions lets add a create() factory that will spit out nullptr or a working instance. stack-info: PR: #9889, branch: strseb/stack/2
strseb
force-pushed
the
strseb/stack/2
branch
from
018ea7a to
a3fc78a
Compare
strseb
added a commit
that referenced
this pull request
Sep 24, 2024
* SplitTunnel 01: Use a factory for creation Currently you need to create the object and then call the correct functions in order to have an initialized object. Similar to wgnt lets make sure that no "invalid" object can even exist. so that we can assert you will not call i.e. start() on a closed handle. Given that it's not cool to have constructors throw exceptions lets add a create() factory that will spit out nullptr or a working instance. stack-info: PR: #9889, branch: strseb/stack/2 * SplitTunnel 02: remove dupe code in generateIPConfiguration Inline Lambdas are cool, let's use them to reduce dupecode and lets give this function a failstate to bubble that up later to the client. stack-info: PR: #9890, branch: strseb/stack/3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
SplitTunnel 01: Use a factory for creation
Currently you need to create the object and then call
the correct functions in order to have an initialized object.
Similar to wgnt lets make sure that no "invalid" object can even exist.
so that we can assert you will not call i.e. start() on a closed handle.
Given that it's not cool to have constructors throw exceptions lets add
a create() factory that will spit out nullptr or a working instance.