SplitTunnel 03: Remove unused functions #9891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strseb
force-pushed
the
strseb/stack/4
branch
from
e87cde0 to
8cddd21
Compare
This was referenced Sep 19, 2024
oskirby
approved these changes
Sep 19, 2024
strseb
force-pushed
the
strseb/stack/4
branch
from
8cddd21 to
d23bf39
Compare
Currently you need to create the object and then call the correct functions in order to have an initialized object. Similar to wgnt lets make sure that no "invalid" object can even exist. so that we can assert you will not call i.e. start() on a closed handle. Given that it's not cool to have constructors throw exceptions lets add a create() factory that will spit out nullptr or a working instance. stack-info: PR: #9889, branch: strseb/stack/2
Inline Lambdas are cool, let's use them to reduce dupecode and lets give this function a failstate to bubble that up later to the client. stack-info: PR: #9890, branch: strseb/stack/3
Whey arent just used? stack-info: PR: #9891, branch: strseb/stack/4
strseb
force-pushed
the
strseb/stack/4
branch
from
d23bf39 to
fb3d4e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
SplitTunnel 03: Remove unused functions
Whey arent just used?