Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Multiple Partner Addons #22888

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Allow Multiple Partner Addons #22888

wants to merge 38 commits into from

Conversation

chrstinalin
Copy link
Contributor

@chrstinalin chrstinalin commented Nov 24, 2024

Fixes mozilla/addons#14986

Description

Allows addons to be a part of multiple add-on groups.

image image

Note: Frontend breaks without mozilla/addons-frontend#13343

Testing

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@chrstinalin chrstinalin marked this pull request as draft November 24, 2024 15:45
@chrstinalin chrstinalin force-pushed the #14986-partner-addons branch from b8b3a9a to 16d4576 Compare November 25, 2024 19:17
@chrstinalin chrstinalin force-pushed the #14986-partner-addons branch 2 times, most recently from bb57a01 to 0ee69e4 Compare November 27, 2024 20:42
@chrstinalin chrstinalin force-pushed the #14986-partner-addons branch from 3b4a3c7 to 6431d51 Compare November 28, 2024 16:26
@chrstinalin chrstinalin marked this pull request as ready for review December 4, 2024 20:06
@chrstinalin chrstinalin requested review from a team and KevinMind and removed request for a team December 4, 2024 20:07
@KevinMind
Copy link
Contributor

So to be clear:

Note: Frontend breaks without

Means the frontend PR should land first. right?

@diox
Copy link
Member

diox commented Dec 5, 2024

Means the frontend PR should land first. right?

Yes, and as discussed during our stand-up, we should consider pushing the frontend changes for the 2024.12.12 push but not the addons-server changes, which are a lot more risky and should wait until next year (can land after the tag).

@KevinMind
Copy link
Contributor

@chrstinalin is this PR still ready for review? I haven't seen or done anything since before the break so can you give a 👍 👎 if it is ready?

@chrstinalin chrstinalin force-pushed the #14986-partner-addons branch 5 times, most recently from bc20986 to 5034b0f Compare January 10, 2025 14:25
@chrstinalin chrstinalin force-pushed the #14986-partner-addons branch from 94ac8e6 to cde026a Compare January 10, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Mark some add-ons as Partner add-ons in the reviewer tools
4 participants