ci: Need to run dependency-review.yml for merge queue

[larseggert]

Otherwise merges stall.

[github-actions]

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

• Linux: Debug Release
• macOS: Debug Release
• Windows: Debug Release

[github-actions]

Benchmark results

Performance differences relative to cf72ed4.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.

       time:   [192.79 ns 193.25 ns 193.73 ns]
       change: [-0.4309% -0.0046% +0.3771%] (p = 0.98 > 0.05)
Found 7 outliers among 100 measurements (7.00%)

3 (3.00%) high mild

4 (4.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.

       time:   [232.83 ns 233.37 ns 233.94 ns]
       change: [-0.4303% -0.0527% +0.3754%] (p = 0.80 > 0.05)
Found 11 outliers among 100 measurements (11.00%)

7 (7.00%) high mild

4 (4.00%) high severe

coalesce_acked_from_zero 10+1 entries: Change within noise threshold.

       time:   [233.19 ns 234.19 ns 235.34 ns]
       change: [+0.3205% +0.8815% +1.6535%] (p = 0.00 < 0.05)
Found 16 outliers among 100 measurements (16.00%)

2 (2.00%) low mild

1 (1.00%) high mild

13 (13.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.

       time:   [211.86 ns 219.58 ns 236.79 ns]
       change: [-1.3616% +1.0396% +5.4877%] (p = 0.75 > 0.05)
Found 20 outliers among 100 measurements (20.00%)

12 (12.00%) low mild

1 (1.00%) high mild

7 (7.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.

       time:   [119.28 ms 119.37 ms 119.45 ms]
       change: [+0.3959% +0.4744% +0.5670%] (p = 0.00 < 0.05)
Found 2 outliers among 100 measurements (2.00%)

2 (2.00%) high mild

transfer/Run multiple transfers with varying seeds: Change within noise threshold.

       time:   [121.28 ms 121.58 ms 121.87 ms]
       thrpt:  [32.821 MiB/s 32.899 MiB/s 32.982 MiB/s]
change:
       time:   [-0.6841% -0.3435% -0.0121%] (p = 0.04 < 0.05)
       thrpt:  [+0.0121% +0.3447% +0.6888%]
Found 5 outliers among 100 measurements (5.00%)

1 (1.00%) low severe

4 (4.00%) low mild

transfer/Run multiple transfers with the same seed: Change within noise threshold.

       time:   [121.37 ms 121.53 ms 121.70 ms]
       thrpt:  [32.868 MiB/s 32.913 MiB/s 32.957 MiB/s]
change:
       time:   [-0.8092% -0.6262% -0.4333%] (p = 0.00 < 0.05)
       thrpt:  [+0.4352% +0.6301% +0.8158%]
Found 2 outliers among 100 measurements (2.00%)

1 (1.00%) low mild

1 (1.00%) high mild

1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.

       time:   [1.1005 s 1.1250 s 1.1581 s]
       thrpt:  [86.347 MiB/s 88.889 MiB/s 90.867 MiB/s]
change:
       time:   [-4.5176% -1.7482% +1.2760%] (p = 0.30 > 0.05)
       thrpt:  [-1.2599% +1.7793% +4.7313%]
Found 2 outliers among 10 measurements (20.00%)

2 (20.00%) high severe

1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.

       time:   [440.08 ms 442.47 ms 444.87 ms]
       thrpt:  [22.478 Kelem/s 22.600 Kelem/s 22.723 Kelem/s]
change:
       time:   [-0.0608% +0.7155% +1.5131%] (p = 0.07 > 0.05)
       thrpt:  [-1.4905% -0.7104% +0.0608%]
Found 1 outliers among 100 measurements (1.00%)

1 (1.00%) high mild

1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.

       time:   [45.071 ms 45.287 ms 45.513 ms]
       thrpt:  [21.972  elem/s 22.082  elem/s 22.187  elem/s]
change:
       time:   [-0.8949% -0.2159% +0.4016%] (p = 0.53 > 0.05)
       thrpt:  [-0.4000% +0.2164% +0.9029%]
Found 2 outliers among 100 measurements (2.00%)

1 (1.00%) high mild

1 (1.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client	Server	CC	Pacing	Mean [ms]	Min [ms]	Max [ms]	Relative
msquic	msquic			252.6 ± 121.3	108.5	573.8	1.00
neqo	msquic	reno	on	340.2 ± 108.0	257.9	582.0	1.00
neqo	msquic	reno		330.3 ± 82.0	259.7	457.0	1.00
neqo	msquic	cubic	on	316.2 ± 76.5	260.6	463.5	1.00
neqo	msquic	cubic		321.3 ± 89.6	254.3	465.0	1.00
msquic	neqo	reno	on	977.7 ± 44.8	943.3	1090.6	1.00
msquic	neqo	reno		976.2 ± 56.0	935.8	1073.7	1.00
msquic	neqo	cubic	on	946.1 ± 24.2	922.5	1006.5	1.00
msquic	neqo	cubic		932.1 ± 43.7	890.9	1009.4	1.00
neqo	neqo	reno	on	1007.2 ± 59.5	959.9	1162.8	1.00
neqo	neqo	reno		967.5 ± 54.4	933.9	1120.2	1.00
neqo	neqo	cubic	on	989.7 ± 68.0	932.9	1148.6	1.00
neqo	neqo	cubic		962.4 ± 42.5	932.2	1061.8	1.00

⬇️ Download logs