Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NumPy installation on Mac OS X Travis build #1839

Merged
merged 24 commits into from
Nov 18, 2020

Conversation

lekshmideepu
Copy link
Contributor

Fixing the issues with cython,numpy and matplotlib on OsX under Travis after the upgrade of Python to 3.9.0
Fix #1822

@lekshmideepu lekshmideepu marked this pull request as draft November 12, 2020 13:47
@lekshmideepu lekshmideepu marked this pull request as ready for review November 13, 2020 13:41
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lekshmideepu Thanks! It looks mostly good, but see my comments. I am afraid the tests will presently no make it to the OSX stage because of the strict test on the number of warnings.

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
lekshmideepu and others added 3 commits November 13, 2020 17:47
Co-authored-by: Jochen Martin Eppler <[email protected]>
Co-authored-by: Jochen Martin Eppler <[email protected]>
@heplesser
Copy link
Contributor

@lekshmideepu I manually started the macOS test (it does not run automatically because the full-build test fails because of warnings-count), see https://travis-ci.org/github/nest/nest-simulator/jobs/743499027. All builds, but the nosetest install fails. I will make a suggestion as inline comment.

Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lekshmideepu I added some suggestions for user-local install of nosetests to avoid permissions problems when pip tries to install man pages.

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
extras/travis_build.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lekshmideepu Progress ... see some suggestions below, hopefully taking us yet further towards success ;).

extras/travis_build.sh Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@heplesser
Copy link
Contributor

See also #1852, which will solve the problems with the currently failing "full" build.

Co-authored-by: Hans Ekkehard Plesser <[email protected]>
@jougs
Copy link
Contributor

jougs commented Nov 18, 2020

@lekshmideepu: Please pull master. The problems with the warnings should be gone now that #1852 is merged.

.travis.yml Show resolved Hide resolved
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine once Travis is. I'll commit my minor suggestion right before merging.

@heplesser
Copy link
Contributor

All green again 👍 !!!

Co-authored-by: Jochen Martin Eppler <[email protected]>
@lekshmideepu
Copy link
Contributor Author

Finally :-) Thanks for the reviews @heplesser and @jougs 👍

@jougs jougs changed the title Fixing the broken MacOS Travis build Update NumPy installation on Mac OS X Travis build Nov 18, 2020
@jougs jougs merged commit c354d42 into nest:master Nov 18, 2020
@terhorstd terhorstd added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Development

Successfully merging this pull request may close these issues.

MacOS stage of Travis CI is broken
4 participants