Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: user:settings command when user is not available #47889

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix: user:settings command when user is not available #47889

merged 1 commit into from
Jan 28, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 11, 2024 •
edited
Loading

Summary

If ignore-missing-user all sub commands work, except listing all settings for a user like occ user:settings --ignore-missing-user user core.

Checklist

@susnux susnux added bug 3. to review Waiting for reviews labels Sep 11, 2024
@susnux susnux added this to the Nextcloud 31 milestone Sep 11, 2024
@susnux susnux requested review from a team, skjnldsv, yemkareems and come-nc and removed request for a team September 11, 2024 09:30
@susnux
Copy link
Contributor Author

susnux commented Sep 11, 2024

/backport to stable30

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 15, 2024
@skjnldsv skjnldsv marked this pull request as draft November 15, 2024 13:13
@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 27, 2025
@susnux susnux marked this pull request as ready for review January 27, 2025 11:56
@susnux
Copy link
Contributor Author

susnux commented Jan 27, 2025

/backport to stable31

@susnux susnux force-pushed the fix/settings-command branch from 57f1064 to df2684b Compare January 27, 2025 11:57
@susnux susnux requested a review from come-nc January 27, 2025 13:14
come-nc
come-nc reviewed Jan 27, 2025
View reviewed changes
core/Command/User/Setting.php Outdated Show resolved Hide resolved
core/Command/User/Setting.php Outdated Show resolved Hide resolved
@susnux susnux force-pushed the fix/settings-command branch from df2684b to eae1911 Compare January 27, 2025 19:50
@susnux susnux requested a review from come-nc January 27, 2025 19:50
@susnux
fix: user:settings command when user is not available
5867231 
If `ignore-missing-user` all sub commands work, except listing all settings
for a user like `occ user:settings --ignore-missing-user user core`.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/settings-command branch from eae1911 to 5867231 Compare January 27, 2025 19:51
@come-nc come-nc merged commit e4e9dae into master Jan 28, 2025
189 checks passed
@come-nc come-nc deleted the fix/settings-command branch January 28, 2025 08:37
@backportbot backportbot bot mentioned this pull request Jan 28, 2025
Merged
@backportbot backportbot bot mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @skjnldsv @come-nc