[PRMP-1302] Create sandbox for NRL API #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
infrastructure/api.tf
Outdated
| ] | ||
|
|
||
| lifecycle { | ||
| create_before_destroy = true | ||
| } | ||
| } | ||
|
|
||
| resource "aws_api_gateway_stage" "ndr_api" { |
There was a problem hiding this comment.
Is there a better name than ndr_api that describes the stage?
| } | ||
|
|
||
|
|
||
| resource "aws_api_gateway_integration" "get_document_reference_mock_integration" { |
| path_part = "DocumentReference" | ||
| } | ||
|
|
||
| resource "aws_api_gateway_resource" "sandbox_get_document_reference_path_parametre" { |
steph-torres-nhs
had a problem deploying
to
development
GitHub Actions
Failure
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
chrisbloe-nhse
force-pushed
the
PRMP-1302
branch
from
1434b77 to
e2d791d
Compare
chrisbloe-nhse
temporarily deployed
to
development
GitHub Actions
Inactive
| }, | ||
| "content": [ | ||
| { | ||
| "attachment": { |
There was a problem hiding this comment.
Are we not including the size/hash of the document in the pointer?
jack-nhs
approved these changes
Jan 29, 2025
danielleandersonNHS
approved these changes
Jan 29, 2025
robg-nhs
previously requested changes
Jan 31, 2025
robg-nhs
reviewed
Jan 31, 2025
robg-nhs
had a problem deploying
to
development
GitHub Actions
Failure
robg-nhs
had a problem deploying
to
development
GitHub Actions
Failure
steph-torres-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
steph-torres-nhs
dismissed
robg-nhs’s stale review
Double checked with Rob, ok to go ahead, he has made the required changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from PRMP-1286