-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRMP-1302] Create sandbox for NRL API #232
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e359270
[PRMP-1302] Create sandbox for nrl api with stubbed responses
NogaNHS e2575d0
[PRMP-1302] address PR comments
steph-torres-nhs facaa56
[PRMP-1302] fix typos
steph-torres-nhs e2d791d
[PRMP-1302] add spacing after diagnositcs
steph-torres-nhs 9cae8e5
Merge branch 'main' into PRMP-1302
NogaNHS 9b5e968
Remove the mock 400 response
robg-nhs a600f3b
Remove 400 Error response and default to 404 if no record
robg-nhs 3bd6c0e
Removed some extra 400 error resources
robg-nhs 8de2cd6
Merge branch 'main' into PRMP-1302
steph-torres-nhs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| locals { | ||
| mock_200_response = file("${path.module}/nrl_mock_responses/200_response.json") | ||
| mock_401_response = file("${path.module}/nrl_mock_responses/401_response.json") | ||
| mock_403_response = file("${path.module}/nrl_mock_responses/403_response.json") | ||
| mock_404_response = file("${path.module}/nrl_mock_responses/404_response.json") | ||
| } | ||
|
|
||
| resource "aws_api_gateway_resource" "nrl_sandbox" { | ||
| rest_api_id = aws_api_gateway_rest_api.ndr_doc_store_api.id | ||
| parent_id = aws_api_gateway_rest_api.ndr_doc_store_api.root_resource_id | ||
| path_part = "sandbox" | ||
| } | ||
|
|
||
| resource "aws_api_gateway_resource" "sandbox_get_document_reference" { | ||
| rest_api_id = aws_api_gateway_rest_api.ndr_doc_store_api.id | ||
| parent_id = aws_api_gateway_resource.nrl_sandbox.id | ||
| path_part = "DocumentReference" | ||
| } | ||
|
|
||
| resource "aws_api_gateway_resource" "sandbox_get_document_reference_path_parameter" { | ||
| rest_api_id = aws_api_gateway_rest_api.ndr_doc_store_api.id | ||
| parent_id = aws_api_gateway_resource.sandbox_get_document_reference.id | ||
| path_part = "{id}" | ||
| } | ||
|
|
||
| resource "aws_api_gateway_method" "sandbox_get_document_reference" { | ||
| rest_api_id = aws_api_gateway_rest_api.ndr_doc_store_api.id | ||
| resource_id = aws_api_gateway_resource.sandbox_get_document_reference_path_parameter.id | ||
| http_method = "GET" | ||
| authorization = "NONE" | ||
| api_key_required = true | ||
| request_parameters = { | ||
| "method.request.path.id" = true | ||
| } | ||
| } | ||
|
|
||
|
|
||
| resource "aws_api_gateway_integration" "get_document_reference_mock" { | ||
| rest_api_id = aws_api_gateway_rest_api.ndr_doc_store_api.id | ||
| resource_id = aws_api_gateway_resource.sandbox_get_document_reference_path_parameter.id | ||
| type = "MOCK" | ||
| http_method = aws_api_gateway_method.sandbox_get_document_reference.http_method | ||
| request_templates = { | ||
| "application/json" = <<EOF | ||
| { | ||
| #if ( $input.params('id') == '16521000000101~f9ed81db-f90a-42d4-b7e4-d554d8f338fd' ) | ||
| "statusCode": 200 | ||
| #elseif ( $input.params('id') == '401' ) | ||
| "statusCode": 401 | ||
| #elseif ( $input.params('id') == '403' ) | ||
| "statusCode": 403 | ||
| #else | ||
| "statusCode": 404 | ||
| #end | ||
| } | ||
| EOF | ||
| } | ||
| } | ||
|
|
||
| resource "aws_api_gateway_method_response" "response_200" { | ||
| rest_api_id = aws_api_gateway_rest_api.ndr_doc_store_api.id | ||
| resource_id = aws_api_gateway_resource.sandbox_get_document_reference_path_parameter.id | ||
| http_method = aws_api_gateway_method.sandbox_get_document_reference.http_method | ||
| status_code = "200" | ||
| } | ||
|
|
||
| resource "aws_api_gateway_integration_response" "get_document_reference_mock_200_response" { | ||
| rest_api_id = aws_api_gateway_rest_api.ndr_doc_store_api.id | ||
| resource_id = aws_api_gateway_resource.sandbox_get_document_reference_path_parameter.id | ||
| http_method = aws_api_gateway_method.sandbox_get_document_reference.http_method | ||
| status_code = aws_api_gateway_method_response.response_200.status_code | ||
| selection_pattern = "200" | ||
| response_templates = { | ||
| "application/json" = local.mock_200_response | ||
| } | ||
| } | ||
|
|
||
| resource "aws_api_gateway_method_response" "response_401" { | ||
| rest_api_id = aws_api_gateway_rest_api.ndr_doc_store_api.id | ||
| resource_id = aws_api_gateway_resource.sandbox_get_document_reference_path_parameter.id | ||
| http_method = aws_api_gateway_method.sandbox_get_document_reference.http_method | ||
| status_code = "401" | ||
| } | ||
|
|
||
| resource "aws_api_gateway_integration_response" "get_document_reference_mock_401_response" { | ||
| rest_api_id = aws_api_gateway_rest_api.ndr_doc_store_api.id | ||
| resource_id = aws_api_gateway_resource.sandbox_get_document_reference_path_parameter.id | ||
| http_method = aws_api_gateway_method.sandbox_get_document_reference.http_method | ||
| status_code = aws_api_gateway_method_response.response_401.status_code | ||
| selection_pattern = "401" | ||
| response_templates = { | ||
| "application/json" = local.mock_401_response | ||
| } | ||
| } | ||
|
|
||
| resource "aws_api_gateway_method_response" "response_403" { | ||
| rest_api_id = aws_api_gateway_rest_api.ndr_doc_store_api.id | ||
| resource_id = aws_api_gateway_resource.sandbox_get_document_reference_path_parameter.id | ||
| http_method = aws_api_gateway_method.sandbox_get_document_reference.http_method | ||
| status_code = "403" | ||
| } | ||
|
|
||
| resource "aws_api_gateway_integration_response" "get_document_reference_mock_403_response" { | ||
| rest_api_id = aws_api_gateway_rest_api.ndr_doc_store_api.id | ||
| resource_id = aws_api_gateway_resource.sandbox_get_document_reference_path_parameter.id | ||
| http_method = aws_api_gateway_method.sandbox_get_document_reference.http_method | ||
| status_code = aws_api_gateway_method_response.response_403.status_code | ||
| selection_pattern = "403" | ||
| response_templates = { | ||
| "application/json" = local.mock_403_response | ||
| } | ||
| } | ||
|
|
||
| resource "aws_api_gateway_method_response" "response_404" { | ||
| rest_api_id = aws_api_gateway_rest_api.ndr_doc_store_api.id | ||
| resource_id = aws_api_gateway_resource.sandbox_get_document_reference_path_parameter.id | ||
| http_method = aws_api_gateway_method.sandbox_get_document_reference.http_method | ||
| status_code = "404" | ||
| } | ||
|
|
||
| resource "aws_api_gateway_integration_response" "get_document_reference_mock_404_response" { | ||
| rest_api_id = aws_api_gateway_rest_api.ndr_doc_store_api.id | ||
| resource_id = aws_api_gateway_resource.sandbox_get_document_reference_path_parameter.id | ||
| http_method = aws_api_gateway_method.sandbox_get_document_reference.http_method | ||
| status_code = aws_api_gateway_method_response.response_404.status_code | ||
| selection_pattern = "404" | ||
| response_templates = { | ||
| "application/json" = local.mock_404_response | ||
| } | ||
| } | ||
|
|
||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| { | ||
| "resourceType": "DocumentReference", | ||
| "status": "current", | ||
| "type": { | ||
| "coding": [ | ||
| { | ||
| "system": "http://snomed.info/sct", | ||
| "code": "16521000000101", | ||
| "display": "Lloyd George record folder" | ||
| } | ||
| ] | ||
| }, | ||
| "category": [ | ||
| { | ||
| "coding": [ | ||
| { | ||
| "system": "http://snomed.info/sct", | ||
| "code": "734163000", | ||
| "display": "Care plan" | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "subject": { | ||
| "identifier": { | ||
| "system": "https://fhir.nhs.uk/Id/nhs-number", | ||
| "value": "9000000009" | ||
| } | ||
| }, | ||
| "author": [ | ||
| { | ||
| "identifier": { | ||
| "system": "https://fhir.nhs.uk/Id/ods-organization-code", | ||
| "value": "Y12345" | ||
| } | ||
| } | ||
| ], | ||
| "custodian": { | ||
| "identifier": { | ||
| "system": "https://fhir.nhs.uk/Id/ods-organization-code", | ||
| "value": "Y12345" | ||
| } | ||
| }, | ||
| "content": [ | ||
| { | ||
| "attachment": { | ||
| "contentType": "application/pdf", | ||
| "language": "en-GB", | ||
| "url": "https://fake-url.com", | ||
| "title": "document.pdf", | ||
| "creation": "2024-01-01T12:00:00.000Z" | ||
| }, | ||
| "format": { | ||
| "system": "https://fhir.nhs.uk/England/CodeSystem/England-NRLFormatCode", | ||
| "code": "urn:nhs-ic:unstructured", | ||
| "display": "Unstructured Document" | ||
| }, | ||
| "extension": [ | ||
| { | ||
| "valueCodeableConcept": { | ||
| "coding": [ | ||
| { | ||
| "system": "https://fhir.nhs.uk/England/CodeSystem/England-NRLContentStability", | ||
| "code": "static", | ||
| "display": "Static" | ||
| } | ||
| ] | ||
| }, | ||
| "url": "https://fhir.nhs.uk/England/StructureDefinition/Extension-England-ContentStability" | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "context": { | ||
| "practiceSetting": { | ||
| "coding": [ | ||
| { | ||
| "system": "http://snomed.info/sct", | ||
| "code": "1060971000000108", | ||
| "display": "General practice service" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "resourceType": "OperationOutcome", | ||
| "issue": [ | ||
| { | ||
| "severity": "error", | ||
| "code": "exception", | ||
| "details": { | ||
| "coding": [ | ||
| { | ||
| "system": "http://hl7.org/fhir/issue-type", | ||
| "code": "unknown", | ||
| "display": "Unknown" | ||
| } | ||
| ] | ||
| }, | ||
| "diagnostics": "User is unauthorised to view record" | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "resourceType": "OperationOutcome", | ||
| "issue": [ | ||
| { | ||
| "severity": "error", | ||
| "code": "exception", | ||
| "details": { | ||
| "coding": [ | ||
| { | ||
| "system": "http://hl7.org/fhir/issue-type", | ||
| "code": "forbidden", | ||
| "display": "Forbidden" | ||
| } | ||
| ] | ||
| }, | ||
| "diagnostics": "An error occurred while fetching the document" | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "resourceType": "OperationOutcome", | ||
| "issue": [ | ||
| { | ||
| "severity": "error", | ||
| "code": "exception", | ||
| "details": { | ||
| "coding": [ | ||
| { | ||
| "system": "http://hl7.org/fhir/issue-type", | ||
| "code": "not-found", | ||
| "display": "Not Found" | ||
| } | ||
| ] | ||
| }, | ||
| "diagnostics": "Document reference not found" | ||
| } | ||
| ] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we not including the size/hash of the document in the pointer?