feat(core): introduce continuous tasks #29750
Open
+1,845
−856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit d54fcbe.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
force-pushed
the
continuous-tasks
branch
from
66b73fc to
3ce0b72
Compare
FrozenPandaz
force-pushed
the
continuous-tasks
branch
from
3ce0b72 to
9704043
Compare
FrozenPandaz
force-pushed
the
continuous-tasks
branch
from
9704043 to
6273072
Compare
FrozenPandaz
force-pushed
the
continuous-tasks
branch
from
6273072 to
b33ed45
Compare
FrozenPandaz
force-pushed
the
continuous-tasks
branch
from
b33ed45 to
cc9549c
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-29750-cc9549c
To request a new release for this pull request, mention someone from the Nx team or the |
FrozenPandaz
force-pushed
the
continuous-tasks
branch
from
cc9549c to
91e243b
Compare
FrozenPandaz
force-pushed
the
continuous-tasks
branch
from
8bed8d6 to
a0967d3
Compare
FrozenPandaz
force-pushed
the
continuous-tasks
branch
3 times, most recently
from
bd960c0 to
80f6267
Compare
FrozenPandaz
commented
Jan 31, 2025
| !shouldPrefix | ||
| ) { | ||
| // todo implement this | ||
| // return await this.runTaskInForkedProcess( |
There was a problem hiding this comment.
Removing this
| @@ -725,4 +767,87 @@ export class TaskOrchestrator { | |||
| } | |||
|
|
|||
| // endregion utils | |||
| private async startInfiniteTask( | |||
There was a problem hiding this comment.
Change this to continuous
| @@ -135,18 +135,37 @@ export class PseudoTerminal { | |||
| } | |||
| } | |||
|
|
|||
| let i = 0; | |||
| @@ -30,19 +31,37 @@ describe('PseudoTerminal', () => { | |||
| }, 1000); | |||
|
|
|||
| it('should subscribe to output', (done) => { | |||
| const childProcess = terminal.runCommand('echo "hello world"'); | |||
| const childProcess = terminal.runCommand('sleep 1 && echo "hello world"'); | |||
FrozenPandaz
force-pushed
the
continuous-tasks
branch
from
1d9c69a to
d54fcbe
Compare
FrozenPandaz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An RFC about this feature is happening here: #29025. This has the most information about this feature.
Current Behavior
Nx currently does not explicitly handle tasks which run continuously until they are terminated.
Expected Behavior
This PR adds the initial support for continuous tasks which run continuously until they are terminated. This adds the ability to depend on continuous tasks. There is some more work to be done but this will be enough as an MVP.
Related Issue(s)
Fixes #