Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional title for chrome.history.addUrl #73

Open
wants to merge 3 commits into
base: nw22
Choose a base branch
from
Open

Optional title for chrome.history.addUrl #73

wants to merge 3 commits into from

Conversation

janRucka
Copy link
Contributor

@janRucka janRucka commented Mar 7, 2017 •
edited
Loading

This was referenced Mar 7, 2017
Closed
Closed
@rogerwang rogerwang force-pushed the nw21 branch 4 times, most recently from c286db2 to aa1726c Compare March 10, 2017 05:25
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
base: Make TimeDurationFormat* report failures.
eaf9c66 
Update base::TimeDurationFormat() and
base::TimeDurationFormatWithSeconds() to return boolean
"success" values and use out-params to return formatted
strings. ICU errors were formerly swallowed, which makes it
impossible for the UI to handle them gracefully or for
developers to investigate their causes.

BUG=698802,677043

Review-Url: https://codereview.chromium.org/2734883003
Cr-Commit-Position: refs/heads/master@{#455144}
(cherry picked from commit efcd30c)

Review-Url: https://codereview.chromium.org/2736363002 .
Cr-Commit-Position: refs/branch-heads/3029@{#73}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
@rogerwang rogerwang force-pushed the nw21 branch 9 times, most recently from 0cd811f to 9af025f Compare March 16, 2017 22:11
@rogerwang rogerwang force-pushed the nw21 branch 3 times, most recently from f78c16a to 319d6c0 Compare March 21, 2017 07:40
@rogerwang rogerwang force-pushed the nw21 branch 3 times, most recently from b060cdf to 1e188d1 Compare March 29, 2017 05:19
@janRucka janRucka force-pushed the chromeHistoryTitle21 branch from 79223fb to d4c5654 Compare March 29, 2017 14:23
@janRucka
Copy link
Contributor Author

Updated to current nw21.

@rogerwang rogerwang force-pushed the nw21 branch 6 times, most recently from 8adf1c9 to 78ca434 Compare April 4, 2017 23:23
@rogerwang rogerwang force-pushed the nw21 branch 2 times, most recently from f1e4ded to 4fd96a3 Compare April 6, 2017 01:18
@rogerwang rogerwang force-pushed the nw21 branch 3 times, most recently from 27692f7 to f854061 Compare April 12, 2017 13:01
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
Incrementing VERSION to 59.0.3071.15
b3f9fb3 
Cr-Commit-Position: refs/branch-heads/3071@{#73}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
@janRucka janRucka force-pushed the chromeHistoryTitle21 branch from d4c5654 to 87e1d8e Compare May 5, 2017 13:52
@janRucka janRucka changed the base branch from nw21 to nw22 May 5, 2017 13:53
@janRucka
Copy link
Contributor Author

janRucka commented May 5, 2017

We updated some of our pull request to current nw22 branch:
#74
#72
(this one)

Is there anything more we can do to get our changes merged?

@rogerwang rogerwang force-pushed the nw22 branch 4 times, most recently from 65748ff to 90fd209 Compare May 10, 2017 06:28
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
Policy to disable/whitelist lock screen note taking apps
e87856f 
Adds a policy to control whether/which note taking apps are allowed
on the lock screen - the policy is implemented as a white-list of
apps that will be allowed as lock screen note taking apps (provided
the user enables them in settings).

The policy value is saved as kNoteTakingAppsAllowedOnLockScreen pref
that's being added in https://chromium-review.googlesource.com/c/572842

BUG=741053
[email protected]

(cherry picked from commit c45d9b1)

Change-Id: Ib1beb5ee3c7f4efad0eb8be99f894345adaf7530
Reviewed-on: https://chromium-review.googlesource.com/567556
Commit-Queue: Toni Barzic <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489199}
Reviewed-on: https://chromium-review.googlesource.com/588382
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#73}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
@galmacky
Stop notifying autocomplete text state change on selection change
af3eed8 
Selection change at focus gain triggers onAutocompleteTextStateChanged()
and this causes LocationBarLayout and AutocompleteController to stop
generating omnibox suggestions.

BUG=759876

(cherry picked from commit bc99b84)

Change-Id: I96fd12e5ef116862ee44f082b9234a9f4b9c11bd
Reviewed-on: https://chromium-review.googlesource.com/651572
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Changwan Ryu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#500052}
Reviewed-on: https://chromium-review.googlesource.com/656533
Reviewed-by: Changwan Ryu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#73}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
@mcchou-cr
Add UMA metrics for Chrome OS Bluetooth system daemon
e40f3d2 
This adds the following histograms and their definitions.

[Histograms]
- BlueZ.AdapterLost
- BlueZ.NumberOfExistingAdvertisements

BUG=chromium:724720
[email protected]

(cherry picked from commit b5a0727)

Change-Id: I44e8cb0df131efff57582d5bbbda7abe2b16a97b
Reviewed-on: https://chromium-review.googlesource.com/722076
Commit-Queue: Miao-chen Chou <[email protected]>
Reviewed-by: Rahul Chaturvedi <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509544}
Reviewed-on: https://chromium-review.googlesource.com/728349
Reviewed-by: Miao-chen Chou <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#73}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
@jianli-chromium
[M65 Merge] Encode Subject header correctly per RFC 2047
bf03fcb 
Thee're some differences between RFC 2047 which we should be
used to encode header value and RFC 2045 for body:
1) Use CRLF+SPACE for soft line break.
2) SPACE and TAB should always be encoded.
3) Multiple encoded text should be used

Did manual test with FAR file manager w/ Observer plugin and
7-Zip w/ eDecoder plugin.

[email protected]

(cherry picked from commit a97e4b2)

Bug: 794835
Change-Id: I5b87b7392d2208dd58bf512c7ee59c87bc32a85a
Reviewed-on: https://chromium-review.googlesource.com/835009
Reviewed-by: Xianzhu Wang <[email protected]>
Reviewed-by: Łukasz Anforowicz <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Jian Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#530371}
Reviewed-on: https://chromium-review.googlesource.com/884512
Reviewed-by: Jian Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#73}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
@sebmarchand
Fix 2 access violation in resource_coordinator.
74361db 
Bug: 818454
Change-Id: I77f6ea60f38ad8956d7f7e042c57202f3f41a07c
Reviewed-on: https://chromium-review.googlesource.com/951749
Commit-Queue: Sébastien Marchand <[email protected]>
Reviewed-by: Chris Hamilton <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#541230}(cherry picked from commit 182f838)
Reviewed-on: https://chromium-review.googlesource.com/953366
Reviewed-by: Sébastien Marchand <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#73}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
@plorcupine
Omnibox/Views: Remove LocationBarView stroke for touch mode.
1e01ecc 
This patch removes the 1px outline on LocationBarView and switches to using a
views::FocusRing in touch mode.

See screenshots -
https://drive.google.com/file/d/1g4O_mh4oPb8PJIAb7pjDq0rK32KIUUvP/view?usp=sharing

[email protected]

(cherry picked from commit b167f41)

Bug: 801583, 829574
Change-Id: I6498ff15d3b1be6a03cab92e9aae8971b54c358e
Reviewed-on: https://chromium-review.googlesource.com/1002716
Commit-Queue: Patti <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#550935}
Reviewed-on: https://chromium-review.googlesource.com/1015456
Reviewed-by: Patti <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#73}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
Upload EIDs as bytes.
a479208 
Formally changed the type in the proto (as on server). Also include
a zero byte in the EID in unit tests.

BUG=chromium:840496
TEST=unit_tests

Change-Id: I4e0acaf70547658421c16a8d4731f72f7dc2caa1
Reviewed-on: https://chromium-review.googlesource.com/1079255
Commit-Queue: Yves Arrouye <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#563024}(cherry picked from commit 819405b)
Reviewed-on: https://chromium-review.googlesource.com/1080972
Reviewed-by: Yves Arrouye <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#73}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
[Autofill Views] Draw separator background
d1effdf 
Currently, we don't draw the background on the separator. This is fine
on Win and Mac, because by default we just see white anyway. But on
Linux (specifically GTK+) we draw gray by default, giving an ugly gray
splotch.

Change-Id: I6f6d61d7ade28d30a659858a9a83bf0506aa3637
Bug: 866637
Reviewed-on: https://chromium-review.googlesource.com/1147158
Reviewed-by: Fabio Tirelo <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Fabio Tirelo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#577373}(cherry picked from commit a134926)
Reviewed-on: https://chromium-review.googlesource.com/1150320
Reviewed-by: Tommy Martino <[email protected]>
Cr-Commit-Position: refs/branch-heads/3497@{#73}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
[ios] Adds fixed height for SummaryPageInfo cell
3d3d7a4 
[email protected]

(cherry picked from commit 009890a)

Bug: 879134
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ie3c2b55b86c9710595c87856ce213675facac9b0
Reviewed-on: https://chromium-review.googlesource.com/1199686
Reviewed-by: Mark Cogan <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#588538}
Reviewed-on: https://chromium-review.googlesource.com/1208911
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/3538@{#73}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
[Explore Sites] Adding UMA to capture the result of the ImageDecoder …
dd66965 
…service.

Change-Id: I1a5cca85ac14fcec14a6536b57d8bfa5db211fd6
Reviewed-on: https://chromium-review.googlesource.com/c/1277525
Commit-Queue: Jonathan Freed <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Justin DeWitt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599237}(cherry picked from commit 0ad8cbe)
Reviewed-on: https://chromium-review.googlesource.com/c/1284812
Reviewed-by: Cathy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#73}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
[iOS][MF] Fix constraints on password cell
fe7fa78 
Clears the vertical constraints for reuse.
Removes extra vertical constraints from separator.

Bug: 878388, 845472
Change-Id: I5ba9efdacd2ac642361069b241a9e53956edc215
Reviewed-on: https://chromium-review.googlesource.com/c/1355137
Reviewed-by: Yi Su <[email protected]>
Commit-Queue: Javier Ernesto Flores Robles <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#612609}(cherry picked from commit 3f9e02a)
Reviewed-on: https://chromium-review.googlesource.com/c/1363272
Reviewed-by: Javier Ernesto Flores Robles <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#73}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
@yulunwu2 @michaelpg
Resolve spacing issue between the buttons on 'Registering fingerprint…
10b73a9 
…' screen

Bug: 881624
Change-Id: Ic2efd91bbccc891f98c5e5e7563996cd8fd138cc
Reviewed-on: https://chromium-review.googlesource.com/c/1440069
Reviewed-by: Jacob Dufault <[email protected]>
Reviewed-by: Michael Giuffrida <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626797}(cherry picked from commit ee9c93c)
Reviewed-on: https://chromium-review.googlesource.com/c/1443549
Cr-Commit-Position: refs/branch-heads/3683@{#73}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
Incrementing VERSION to 74.0.3729.10
df786ba 
[email protected]

Change-Id: If480b0d6581226899f40295d7a8ec16bcc2e7de7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518560
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3729@{#73}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janRucka @rogerwang