This repository has been archived by the owner on Nov 7, 2023. It is now read-only.
Handle invalid argument, unavailable ErrorCodes (and refactor OTLP+Arrow receiver tests) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
changed the title
added 3 commits
November 16, 2022 15:48
Codecov ReportBase: 90.64% // Head: 90.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 90.64% 90.83% +0.18%
==========================================
Files 241 241
Lines 13975 13978 +3
==========================================
+ Hits 12668 12697 +29
+ Misses 1065 1042 -23
+ Partials 242 239 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Laurent Quérel <[email protected]>
jaronoff97
approved these changes
Nov 17, 2022
added 3 commits
November 18, 2022 09:04
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes the Receiver to return StatusMessage responses to the sender for non-gRPC errors. These include:
The adapter library added metrics support in recent PRs, this uncomments the associated receiver handling in this PR. (Exporter handling will be done separately.)
Testing: Improves test structure and coverage for OTLP+Arrow receiver by using a mock Arrow adapter and channels to better distinguish normal shutdown (via context.Cancel) from abnormal shutdown (via gRPC send/recv errors).
Depends on f5/otel-arrow-adapter#52Part of #21.