Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Zero Pattern Issue #1253

Merged
merged 4 commits into from
Apr 29, 2022
Merged

Fix Zero Pattern Issue #1253

merged 4 commits into from
Apr 29, 2022

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Apr 21, 2022 •
edited
Loading

Follow-up to #1118. The pattern issue returned 😱

@ax3l ax3l added this to the 0.14.5 milestone Apr 21, 2022
@ax3l ax3l force-pushed the fix-pattern-again branch 3 times, most recently from c9c8d37 to e294cc3 Compare April 22, 2022 21:51
@franzpoeschel
Copy link
Contributor

Inconsistent iteration paddings are correctly read, but they are currently not stored after first parsing.
When accessing an iteration after parsing, it needs to be opened again, using its filename. Currently, that filename is then reconstructed on the fly by using the iteration padding which is wrong.
I've added a commit that stores the filenames and uses the stored ones in favor of reconstructed ones.

ax3l
ax3l commented Apr 26, 2022
View reviewed changes
test/SerialIOTest.cpp Outdated Show resolved Hide resolved
ax3l
ax3l commented Apr 26, 2022
View reviewed changes
Copy link
Member Author

@ax3l ax3l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, that's awesome :)

@ax3l ax3l changed the title [WIP] Fix Zero Pattern Issue Fix Zero Pattern Issue Apr 26, 2022
ax3l and others added 4 commits April 28, 2022 21:49
@ax3l
Test: Demonstrate Pattern Issue
3b21c62 
As in openPMD#1173
@ax3l
JSON: Improve File Open Error Message
d2bf09e 
Include path to file
@franzpoeschel @ax3l
Upon parsing, store each iteration's filename
a2d3e64 
If the padding is inconsistent, a later Iteration::open() needs the
original filename. Trying to compute the filename from the expansion
pattern will lead to wrong filenames.
@ax3l
Fix: Clang-Tidy performance-for-range-copy
5856489
@ax3l ax3l force-pushed the fix-pattern-again branch from b01029e to 5856489 Compare April 29, 2022 04:49
@ax3l ax3l requested a review from franzpoeschel April 29, 2022 05:01
@ax3l ax3l merged commit e40f7c4 into openPMD:dev Apr 29, 2022
@ax3l ax3l deleted the fix-pattern-again branch April 29, 2022 06:15
@ax3l ax3l modified the milestones: 0.14.5, 0.14.6 May 25, 2022
@ax3l
Copy link
Member Author

ax3l commented May 25, 2022 •
edited
Loading

To apply this fix (especially the third commit) on the release-0.14.5 branch, we problably also need to backport first:

This was referenced May 25, 2022
Merged
Merged
@ax3l ax3l modified the milestones: 0.14.6, 0.14.5 May 26, 2022
@ax3l
Copy link
Member Author

ax3l commented May 26, 2022

Ok I think I managed to backport this in #1282 now 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franzpoeschel franzpoeschel Awaiting requested review from franzpoeschel

Assignees

@franzpoeschel franzpoeschel

Labels
affects latest release bug help wanted internal
Projects
None yet
Milestone
0.14.5
Development

Successfully merging this pull request may close these issues.

Pattern Problem Returns in 0.14.3
2 participants
@ax3l @franzpoeschel