-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.14.5 backports #1282
Merged
Merged
Release 0.14.5 backports #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve patch comment
Avoid stripping symbols for Python debug builds, so we can see lines in coredumps and debugger runs.
Update the NVHPC install instructions to the latest and greatest. Fix failing CI (dependency install). Also upgrade to 21.11 as on Perlmutter.
This tries to fix a compile error on Maxwell (DESY). ``` /home/diederse/software/hipace_4GPU/hipace/build/_deps/fetchedopenpmd-src/src/IO/HDF5/HDF5IOHandler.cpp: In member function 'virtual void openPMD::HDF5IOHandlerImpl::readAttribute(openPMD::Writable*, openPMD::Parameter<openPMD::Operation::READ_ATT>&)': /home/diederse/software/hipace_4GPU/hipace/build/_deps/fetchedopenpmd-src/src/IO/HDF5/HDF5IOHandler.cpp:1586:17: error: 'H5free_memory' was not declared in this scope 1586 | H5free_memory(m1); | ^~~~~~~~~~~~~ /home/diederse/software/hipace_4GPU/hipace/build/_deps/fetchedopenpmd-src/src/IO/HDF5/HDF5IOHandler.cpp:1609:17: error: 'H5free_memory' was not declared in this scope 1609 | H5free_memory(m1); | ^~~~~~~~~~~~~ /home/diederse/software/hipace_4GPU/hipace/build/_deps/fetchedopenpmd-src/src/IO/HDF5/HDF5IOHandler.cpp:1628:17: error: 'H5free_memory' was not declared in this scope 1628 | H5free_memory(m2); | ^~~~~~~~~~~~~ ```
Don't know if it is necessary, but looks like we forgot it earlier Add comment
Small numbers, as common for iterations, were flushed to zero in `std::to_string(double)` of the representation of `Iteration` variables: ``` step __repr__ 100 <openPMD.Iteration at t = '0.000000 s'> was: 8.687655225973454e-14 * 1.0 ```
Nvidia has made changes in the signing keys. https://forums.developer.nvidia.com/t/notice-cuda-linux-repository-key-rotation/212771
Update the documentation about HDFFV-11260 and the newly released fixes in release lines.
I marked PRs I had trouble backporting in 0.14.6: https://github.com/openPMD/openPMD-api/milestone/6?closed=1 I would like to at least backport still these since they affect users: |
``` /home/runner/work/openPMD-api/openPMD-api/src/IO/HDF5/HDF5IOHandler.cpp:1835:21: warning: repeated branch in conditional chain [bugprone-branch-clone] isLegacyLibSplashAttr = ^ ```
Include path to file
If the padding is inconsistent, a later Iteration::open() needs the original filename. Trying to compute the filename from the expansion pattern will lead to wrong filenames.
ax3l
force-pushed
the
release-0.14.5-backports
branch
from
May 26, 2022 22:33
5482409
to
67e8d8b
Compare
* Pass-through flushing parameters * CI fixes * Test * Don't flush when opening an iteration * CI fixes * FlushLevel: Use default base class in NVC++ * clang-tidy: Define member defaults of Writable in-class * Update include/openPMD/IO/AbstractIOHandler.hpp Co-authored-by: Axel Huebl <[email protected]>
for more information, see https://pre-commit.ci
* Don't safeguard empty strings while reading * Update TODO Comment * Add missing update for VEC_CLONG_DOUBLE * Ignore deprecated AccessType in SerialIOTest * SerialIOTest: Fix GCC Pragma Check (openPMD#1260) There was a typo in `__GNUC_MINOR__`, causing the test not to work on all GCC versions. Follow-up to openPMD#1213 * Clearly fail when users select a wrong backend * ICC: Unreachable end of function * Fix use after free in ADIOS1IOHandler * Remove unavailable_backend_test Hard to trigger without explicit backend selection, and test coverage is present on dev anyway Co-authored-by: Axel Huebl <[email protected]>
ax3l
force-pushed
the
release-0.14.5-backports
branch
from
June 6, 2022 22:55
235eca0
to
ba0ff8e
Compare
including Changelog
ax3l
force-pushed
the
release-0.14.5-backports
branch
from
June 7, 2022 16:09
ba0ff8e
to
acca2cd
Compare
franzpoeschel
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/openPMD/openPMD-api/milestone/4
Improve Series Parsing, Python & Fix Backend Bugs
This release improves reading back iterations that overflow the specified zero-pattern.
ADIOS1, ADIOS2 and HDF5 backend stability and performance were improved.
Python bindings got additional wheel platform support and various smaller issues were fixed.
Thanks to @ax3l, @franzpoeschel, and @jeanbez for contributing to this release!
Which version am I running?
Python
C++
CLI
# command line option (since 0.12.0): openpmd-ls --version