Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make minor fixes to openfaas workshop labs #166

Conversation

codegold79
Copy link
Contributor

@codegold79 codegold79 commented Dec 18, 2019

Description

Lab 7: fixed a typo by removing a back tick in a k8s command
Lab 11: updated link to Lab 5
Lab 5 (Japanese version): fixed broken image links

Motivation and Context

Changes will make labs more correct and easier to follow.

Fixes issues #161 #164 #163

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

I was able to click to images from my VS Code IDE, as well as go to the correct Lab 5 link.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codegold79 codegold79 closed this Dec 18, 2019
@codegold79 codegold79 reopened this Dec 18, 2019
@codegold79
Copy link
Contributor Author

@alexellis This PR is ready for review.

@alexellis
Copy link
Member

Thanks @codegold79 - this looks good.

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 25e9339 into openfaas:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants