Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make minor fixes to openfaas workshop labs #166

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Make minor fixes to openfaas workshop labs #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3ec1c5
Remove backtick from k8s command in Lab 7
codegold79 Dec 18, 2019
2c6648a
Fix link to Lab 5 from Lab 11
codegold79 Dec 18, 2019
9564eb0
Fix broken image links in Japanese translated Lab 5
codegold79 Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lab11.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,6 @@ $ echo -n "This is a message" | faas-cli invoke hmac-protected --sign hmac --key
HMAC validation failed.
```

As a follow-up task you could apply HMAC to secure your endpoint on `issue-bot` from [lab 5](https://github.com/openfaas/workshop/blob/7f1b0246376b7e4380bb5874655f28254c15f749/lab5.md)
As a follow-up task you could apply HMAC to secure your endpoint on `issue-bot` from [lab 5](https://github.com/openfaas/workshop/blob/master/lab5.md)

You have completed the labs and can return to the [main page](./README.md).
2 changes: 1 addition & 1 deletion lab7.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ docker service logs -f func_queue-worker
#### _Kubernetes_

```
kubectl logs deployment/queue-worker -n openfaas`
kubectl logs deployment/queue-worker -n openfaas
```

## Use an `X-Callback-Url` with requestbin
Expand Down
10 changes: 5 additions & 5 deletions translations/ja/lab5.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ GitHubに戻って先程作った *bot-tester* を開きます
http://fuh83fhfj.ngrok.io/function/issue-bot
```

![](./screenshot/WebhookURLSettings.png)
![](../../screenshot/WebhookURLSettings.png)

*Content-type* には *application/json* を選択

Expand All @@ -95,7 +95,7 @@ http://fuh83fhfj.ngrok.io/function/issue-bot

イベントは **Issues** と **Issue comment** を選択

![](./screenshot/WebhookEventsSettings.png)
![](../../screenshot/WebhookEventsSettings.png)

## webhookの動作確認

Expand Down Expand Up @@ -186,7 +186,7 @@ $ faas-cli up -f issue-bot.yml

このリクエストとレスポンスはGitHubの *Settings* -> *Webhook* のページで確認できます：

![](./screenshot/WebhookResponse.png)
![](../../screenshot/WebhookResponse.png)

## GitHubに応答する

Expand All @@ -196,11 +196,11 @@ $ faas-cli up -f issue-bot.yml

*GitHub profile* -> *Settings/Developer settings* -> *Personal access tokens* で *Generate new token* をクリックします。

![](./screenshot/PersonalAccessTokens.png)
![](../../screenshot/PersonalAccessTokens.png)

「repo」にチェックを入れてリポジトリへのアクセス権を付与します。

![](./screenshot/NewPAT.png)
![](../../screenshot/NewPAT.png)

ページ下部の「Generate Token」ボタンをクリックします。

Expand Down