Reduce SAT warnings #4555
Closed
Reduce SAT warnings #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerfriedrich
force-pushed
the
pr-sat
branch
5 times, most recently
from
2878139 to
fcceb57
Compare
Signed-off-by: Holger Friedrich <[email protected]>
holgerfriedrich
force-pushed
the
pr-sat
branch
from
fcceb57 to
529b384
Compare
J-N-K
reviewed
Jan 19, 2025
| return true; | ||
| } | ||
| return ConfigParser.valueAsOrElse(properties.get(CONFIG_REMOTE_ENABLED), Boolean.class, true); | ||
| // if we can't determine a set property, we use true (default is remote enabled) |
There was a problem hiding this comment.
TBH, I don't think this is an improvement. Looking at the code before I can easily determine what it does, now I have to think about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address PMD warnings.
Cleanup PMD suppressions, add local
// NOPMDtags where readability is preferred over PMD rule.For the remaining SimplifyBooleanReturn warnings, no code change should be done. The code looks cleaner if we keep it as it is.
I did not try to silence this warnings yet. The
NOPMDtag is not well suited, as it needs to be added to the line of theif. Looks ugly.Before:
After:
