Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903936: Update variable names in build.sh documentation #238

Closed

Conversation

asilichenko
Copy link
Contributor

@asilichenko asilichenko commented Jan 7, 2025

Changed variable name CURL_OPTS to CURL_OPTIONS in the documentation block "Some noteworthy control variables" in build.sh.

CURL_OPTIONS is used in the download_using_curl() function in build-support/build-common.sh.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/238/head:pull/238
$ git checkout pull/238

Update a local copy of the PR:
$ git checkout pull/238
$ git pull https://git.openjdk.org/jtreg.git pull/238/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 238

View PR using the GUI difftool:
$ git pr show -t 238

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/238.diff

Using Webrev

Link to Webrev Comment

Changed variable name `CURL_OPTS` to `CURL_OPTIONS` in the documentation block "Some noteworthy control variables" in `build.sh`. 

`CURL_OPTIONS` is used in the `download_using_curl()` function in `build-support/build-common.sh`.
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jan 7, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 7, 2025

Hi @asilichenko, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user asilichenko" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jan 7, 2025

@asilichenko This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903936: Update variable names in build.sh documentation

Reviewed-by: cstein, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sormuras, @irisclark) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@asilichenko
Copy link
Contributor Author

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Jan 7, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 7, 2025

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

Changed variable name WGET_OPTS to WGET_OPTIONS in the documentation block "Some noteworthy control variables" in build.sh.

WGET_OPTIONS is used in the download_using_wget() function in build-support/build-common.sh.
@asilichenko
Copy link
Contributor Author

/signed

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2025

Already processed the signed command

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Jan 20, 2025
@sormuras
Copy link
Member

Thanks for the contribution @asilichenko!

@asilichenko asilichenko changed the title Rename CURL_OPTS to CURL_OPTIONS in build.sh 7903936: Update variable names in build.sh documentation Jan 21, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 21, 2025
@asilichenko asilichenko deleted the fix-curl-error-options branch January 21, 2025 15:55
@asilichenko asilichenko restored the fix-curl-error-options branch January 21, 2025 15:56
@asilichenko asilichenko reopened this Jan 21, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 21, 2025

Webrevs

@asilichenko asilichenko force-pushed the fix-curl-error-options branch from 1469227 to a1c638f Compare January 21, 2025 16:17
@openjdk
Copy link

openjdk bot commented Jan 21, 2025

@asilichenko Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Jan 21, 2025

⚠️ @asilichenko This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@asilichenko
Copy link
Contributor Author

@sormuras done

@sormuras
Copy link
Member

Okay. Let's wait until a Reviewer also checks off this pull request. Next steps will be called out by the OpenJDK bot...

@openjdk
Copy link

openjdk bot commented Jan 21, 2025

⚠️ @asilichenko the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout fix-curl-error-options
$ git commit --author='Preferred Full Name <[email protected]>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 21, 2025
@asilichenko
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 21, 2025
@openjdk
Copy link

openjdk bot commented Jan 21, 2025

@asilichenko
Your change (at version 26d1921) is now ready to be sponsored by a Committer.

@sormuras
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 21, 2025

Going to push as commit 4544d5f.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 21, 2025
@openjdk openjdk bot closed this Jan 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 21, 2025
@openjdk
Copy link

openjdk bot commented Jan 21, 2025

@sormuras @asilichenko Pushed as commit 4544d5f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@asilichenko asilichenko deleted the fix-curl-error-options branch January 21, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants