-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7903936: Update variable names in build.sh documentation #238
Conversation
Changed variable name `CURL_OPTS` to `CURL_OPTIONS` in the documentation block "Some noteworthy control variables" in `build.sh`. `CURL_OPTIONS` is used in the `download_using_curl()` function in `build-support/build-common.sh`.
Hi @asilichenko, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user asilichenko" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
@asilichenko This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sormuras, @irisclark) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/signed |
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
Changed variable name WGET_OPTS to WGET_OPTIONS in the documentation block "Some noteworthy control variables" in build.sh. WGET_OPTIONS is used in the download_using_wget() function in build-support/build-common.sh.
/signed |
Already processed the |
Thanks for the contribution @asilichenko!
|
Webrevs
|
1469227
to
a1c638f
Compare
@asilichenko Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
…fix-curl-error-options
|
@sormuras done |
Okay. Let's wait until a Reviewer also checks off this pull request. Next steps will be called out by the OpenJDK bot... |
|
/integrate |
@asilichenko |
/sponsor |
Going to push as commit 4544d5f. |
@sormuras @asilichenko Pushed as commit 4544d5f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Changed variable name
CURL_OPTS
toCURL_OPTIONS
in the documentation block "Some noteworthy control variables" inbuild.sh
.CURL_OPTIONS
is used in thedownload_using_curl()
function inbuild-support/build-common.sh
.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/238/head:pull/238
$ git checkout pull/238
Update a local copy of the PR:
$ git checkout pull/238
$ git pull https://git.openjdk.org/jtreg.git pull/238/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 238
View PR using the GUI difftool:
$ git pr show -t 238
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/238.diff
Using Webrev
Link to Webrev Comment